From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 69AC2B013 for ; Fri, 8 Sep 2023 15:43:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4A35412B2D for ; Fri, 8 Sep 2023 15:43:07 +0200 (CEST) Received: from lana.proxmox.com (unknown [94.136.29.99]) by firstgate.proxmox.com (Proxmox) with ESMTP for ; Fri, 8 Sep 2023 15:43:06 +0200 (CEST) Received: by lana.proxmox.com (Postfix, from userid 10043) id 65F1D2C08A0; Fri, 8 Sep 2023 15:43:05 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Fri, 8 Sep 2023 15:43:01 +0200 Message-Id: <20230908134304.2009415-4-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230908134304.2009415-1-s.hanreich@proxmox.com> References: <20230908134304.2009415-1-s.hanreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.429 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [plugin.pm] Subject: [pve-devel] [RFC pve-network 3/6] sdn: dhcp: add abstract class for DHCP plugins X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2023 13:43:37 -0000 This abstract class provides several hooks that should be called during the config regeneration process: before_regenerate Should be called before the plugin does any configuration tasks. The main usage for this hook is tearing down old instances. after_regenerate Should be called after the plugin has finished generating any configuration. The main usage for this hook is to perform cleanup and restart / reload services. before_configure Should be called before creating the configuration for a specific DHCP instance, as defined in the dhcp.cfg. This can be used for performing instance-specific setup. after_configure Should be called after the configuration for a specific DHCP instance, as defined in the dhcp.cfg. This will mainly be used for enabling and restarting / reloading a specific instance of a DHCP server. configure_subnet This function configures the DHCP ranges for a given DHCP server and subnet. This will usually involve generating configuration files based on the SDN configuration. Signed-off-by: Stefan Hanreich --- src/PVE/Network/SDN/Dhcp/Makefile | 8 ++++ src/PVE/Network/SDN/Dhcp/Plugin.pm | 76 ++++++++++++++++++++++++++++++ src/PVE/Network/SDN/Makefile | 1 + 3 files changed, 85 insertions(+) create mode 100644 src/PVE/Network/SDN/Dhcp/Makefile create mode 100644 src/PVE/Network/SDN/Dhcp/Plugin.pm diff --git a/src/PVE/Network/SDN/Dhcp/Makefile b/src/PVE/Network/SDN/Dhcp/Makefile new file mode 100644 index 0000000..1e9b6d3 --- /dev/null +++ b/src/PVE/Network/SDN/Dhcp/Makefile @@ -0,0 +1,8 @@ +SOURCES=Plugin.pm + + +PERL5DIR=${DESTDIR}/usr/share/perl5 + +.PHONY: install +install: + for i in ${SOURCES}; do install -D -m 0644 $$i ${PERL5DIR}/PVE/Network/SDN/Dhcp/$$i; done diff --git a/src/PVE/Network/SDN/Dhcp/Plugin.pm b/src/PVE/Network/SDN/Dhcp/Plugin.pm new file mode 100644 index 0000000..31ca9e3 --- /dev/null +++ b/src/PVE/Network/SDN/Dhcp/Plugin.pm @@ -0,0 +1,76 @@ +package PVE::Network::SDN::Dhcp::Plugin; + +use strict; +use warnings; + +use PVE::Cluster; +use PVE::JSONSchema qw(get_standard_option); + +use base qw(PVE::SectionConfig); + +PVE::Cluster::cfs_register_file('sdn/dhcp.cfg', + sub { __PACKAGE__->parse_config(@_); }, + sub { __PACKAGE__->write_config(@_); }, +); + +my $defaultData = { + propertyList => { + type => { + description => "Plugin type.", + format => 'pve-configid', + type => 'string', + }, + node => { + type => 'array', + description => 'A list of nodes where this DHCP server should be deployed', + items => get_standard_option('pve-node'), + }, + 'lease-time' => { + type => 'integer', + description => 'Lifetime for the DHCP leases of this DNS server', + minimum => '1', + }, + }, +}; + +sub private { + return $defaultData; +} + +sub options { + return { + node => { + optional => 1, + }, + 'lease-time' => { + optional => 1, + }, + }; +} + +sub configure_subnet { + my ($class, $dhcp_config, $subnet_config, $range_config) = @_; + die 'implement in sub class'; +} + +sub before_configure { + my ($class, $dhcp_config) = @_; + die 'implement in sub class'; +} + +sub after_configure { + my ($class, $dhcp_config) = @_; + die 'implement in sub class'; +} + +sub before_regenerate { + my ($class) = @_; + die 'implement in sub class'; +} + +sub after_regenerate { + my ($class, $dhcp_config) = @_; + die 'implement in sub class'; +} + +1; diff --git a/src/PVE/Network/SDN/Makefile b/src/PVE/Network/SDN/Makefile index 92cfcd0..848f7d4 100644 --- a/src/PVE/Network/SDN/Makefile +++ b/src/PVE/Network/SDN/Makefile @@ -10,4 +10,5 @@ install: make -C Zones install make -C Ipams install make -C Dns install + make -C Dhcp install -- 2.39.2