From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 62DAB9FC0 for ; Thu, 7 Sep 2023 11:49:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 458144CA9 for ; Thu, 7 Sep 2023 11:49:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 7 Sep 2023 11:49:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1E2A642FCA for ; Thu, 7 Sep 2023 11:49:48 +0200 (CEST) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Thu, 7 Sep 2023 11:49:41 +0200 Message-Id: <20230907094942.74479-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 1/2] ceph: remove global pg bits setting X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2023 09:49:49 -0000 This setting was removed in [1] as part of the v13.0.2 tag. [1] https://github.com/ceph/ceph/commit/e6acf2d1d528a2395947d446a57bec04a3a002dc Signed-off-by: Maximiliano Sandoval --- I did a grep search across multiple projects and I was not able to find more uses of this option. A second pair of eyes might help here. PVE/API2/Ceph.pm | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm index 7e0763cf..a4101dee 100644 --- a/PVE/API2/Ceph.pm +++ b/PVE/API2/Ceph.pm @@ -158,16 +158,6 @@ __PACKAGE__->register_method ({ minimum => 1, maximum => 7, }, - pg_bits => { - description => "Placement group bits, used to specify the " . - "default number of placement groups.\n\nNOTE: 'osd pool " . - "default pg num' does not work for default pools.", - type => 'integer', - default => 6, - optional => 1, - minimum => 6, - maximum => 14, - }, disable_cephx => { description => "Disable cephx authentication.\n\n" . "WARNING: cephx is a security feature protecting against " . @@ -224,11 +214,6 @@ __PACKAGE__->register_method ({ $cfg->{client}->{keyring} = '/etc/pve/priv/$cluster.$name.keyring'; } - if ($param->{pg_bits}) { - $cfg->{global}->{'osd pg bits'} = $param->{pg_bits}; - $cfg->{global}->{'osd pgp bits'} = $param->{pg_bits}; - } - if ($param->{network}) { $cfg->{global}->{'public network'} = $param->{network}; $cfg->{global}->{'cluster network'} = $param->{network}; -- 2.39.2