From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5D1D19625 for ; Mon, 4 Sep 2023 13:39:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3ECDBE254 for ; Mon, 4 Sep 2023 13:39:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 4 Sep 2023 13:39:54 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A3F2841022 for ; Mon, 4 Sep 2023 13:39:54 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 4 Sep 2023 13:39:47 +0200 Message-Id: <20230904113949.940431-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230904113949.940431-1-f.ebner@proxmox.com> References: <20230904113949.940431-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.079 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 3/5] memory: replace deprecated check_running() call X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2023 11:39:57 -0000 PVE::QemuServer::check_running() does both PVE::QemuConfig::assert_config_exists_on_node() PVE::QemuServer::Helpers::vm_running_locally() The former one isn't needed here when doing hotplug, because the API already assert that the VM config exists. It also would introduce a new cyclic dependency between PVE::QemuServer::Memory <-> PVE::QemuConfig with the proposed virtio-mem patch set. In preparation to remove the cyclic include of PVE::QemuServer in the memory module. No functional change intended. Signed-off-by: Fiona Ebner --- PVE/QemuServer/Memory.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm index c5c3a0a6..6ec5ceec 100644 --- a/PVE/QemuServer/Memory.pm +++ b/PVE/QemuServer/Memory.pm @@ -175,7 +175,7 @@ sub foreach_dimm{ sub qemu_memory_hotplug { my ($vmid, $conf, $defaults, $value) = @_; - return $value if !PVE::QemuServer::check_running($vmid); + return $value if !PVE::QemuServer::Helpers::vm_running_locally($vmid); my $sockets = $conf->{sockets} || 1; -- 2.39.2