From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ACF218929 for ; Tue, 22 Aug 2023 12:26:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8F645AE05 for ; Tue, 22 Aug 2023 12:25:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 22 Aug 2023 12:25:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BD0A6432CE for ; Tue, 22 Aug 2023 12:25:38 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Tue, 22 Aug 2023 12:24:48 +0200 Message-ID: <20230822102533.295530-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.039 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [zfs-arc-max.pl, main.rs, config.pm, runenv.pm, install.pm, bootdisk.rs, options.rs, mod.rs, setup.rs] Subject: [pve-devel] [PATCH installer 0/6] fix #4829: set up a lower default limit for the ZFS ARC in the installer X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2023 10:26:10 -0000 Fixes #4829. Introduces a new ZFS install option `arc_max` (aptly named after the corresponding module option `zfs_arc_max`). For PVE installations, this can be adjusted when creating a ZFS RAID under "Advanced Options". The default value is choosen as 10% of system memory, clamped to between 64 MiB as lower limit and 16 GiB as upper limit. For PBS and PMG, the option is (currently) hidden. If the option is set to a non-zero value, a new file /etc/modprobe.d/zfs.conf gets written during install, setting the `zfs_arc_max` module option as appropriate. Tested by installing PVE, PBS and PMG. For PVE, checked that the `zfs` module option gets correctly written & applied, the latter by looking at the output of `arc_summary`. For PBS and PMG, verified that no modprobe options file is created and the ARC size is set to default. Christoph Heiss (6): fix #4829: install: add new ZFS `arc_max` setup option fix #4829: proxinstall: expose new `arc_max` ZFS option for PVE installations fix #4829: test: add tests for new zfs_arc_max calculations tui: views: add optional suffix label for `NumericEditView`s fix #4829: tui: setup: add new ZFS `arc_max` option fix #4829: tui: bootdisk: expose new `arc_max` ZFS option for PVE installations Makefile | 3 + Proxmox/Install.pm | 4 + Proxmox/Install/Config.pm | 1 + Proxmox/Install/RunEnv.pm | 38 +++++++ debian/control | 1 + proxinstall | 15 +++ proxmox-tui-installer/src/main.rs | 2 +- proxmox-tui-installer/src/options.rs | 55 ++++++++++- proxmox-tui-installer/src/setup.rs | 2 + proxmox-tui-installer/src/views/bootdisk.rs | 59 ++++++++--- proxmox-tui-installer/src/views/mod.rs | 104 +++++++++++++++----- test/Makefile | 10 ++ test/zfs-arc-max.pl | 81 +++++++++++++++ 13 files changed, 333 insertions(+), 42 deletions(-) create mode 100644 test/Makefile create mode 100755 test/zfs-arc-max.pl -- 2.41.0