From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B59CE8227 for ; Mon, 21 Aug 2023 15:45:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8B1931579 for ; Mon, 21 Aug 2023 15:44:54 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 21 Aug 2023 15:44:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B013742D73 for ; Mon, 21 Aug 2023 15:44:53 +0200 (CEST) From: Lukas Wagner To: pve-devel@lists.proxmox.com Date: Mon, 21 Aug 2023 15:44:40 +0200 Message-Id: <20230821134444.620021-4-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230821134444.620021-1-l.wagner@proxmox.com> References: <20230821134444.620021-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC proxmox 3/7] sys: fs: remove unnecessary clippy allow directive X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2023 13:45:24 -0000 It seems like the mentioned clippy bug has since been fixed. Signed-off-by: Lukas Wagner --- proxmox-sys/src/fs/dir.rs | 4 ---- proxmox-sys/src/fs/mod.rs | 2 -- 2 files changed, 6 deletions(-) diff --git a/proxmox-sys/src/fs/dir.rs b/proxmox-sys/src/fs/dir.rs index 72bf1ad..0c1d151 100644 --- a/proxmox-sys/src/fs/dir.rs +++ b/proxmox-sys/src/fs/dir.rs @@ -18,8 +18,6 @@ use crate::fs::{fchown, CreateOptions}; /// /// Errors if the directory already exists. pub fn create_dir>(path: P, options: CreateOptions) -> Result<(), nix::Error> { - // clippy bug?: from_bits_truncate is actually a const fn... - #[allow(clippy::or_fun_call)] let mode: stat::Mode = options .perm .unwrap_or(stat::Mode::from_bits_truncate(0o770)); @@ -130,8 +128,6 @@ fn create_path_at_do( final_opts.as_ref() }; - // clippy bug?: from_bits_truncate is actually a const fn... - #[allow(clippy::or_fun_call)] let mode = opts .and_then(|o| o.perm) .unwrap_or(stat::Mode::from_bits_truncate(0o755)); diff --git a/proxmox-sys/src/fs/mod.rs b/proxmox-sys/src/fs/mod.rs index 8fb677c..ae54d78 100644 --- a/proxmox-sys/src/fs/mod.rs +++ b/proxmox-sys/src/fs/mod.rs @@ -69,8 +69,6 @@ impl CreateOptions { } pub fn apply_to(&self, file: &mut File, path: &Path) -> Result<(), Error> { - // clippy bug?: from_bits_truncate is actually a const fn... - #[allow(clippy::or_fun_call)] let mode: stat::Mode = self.perm.unwrap_or(stat::Mode::from_bits_truncate(0o644)); if let Err(err) = stat::fchmod(file.as_raw_fd(), mode) { -- 2.39.2