From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6FDD0CB8A for ; Wed, 16 Aug 2023 11:55:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 58D0613CA3 for ; Wed, 16 Aug 2023 11:55:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 16 Aug 2023 11:55:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 01F3340A5C for ; Wed, 16 Aug 2023 11:55:02 +0200 (CEST) From: Filip Schauer To: pve-devel@lists.proxmox.com Date: Wed, 16 Aug 2023 11:54:57 +0200 Message-Id: <20230816095457.30340-1-f.schauer@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 manager] fix #4663: Prevent Web UI reload on cert order for other node X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2023 09:55:04 -0000 While it makes sense to reload the Web UI after ordering a certificate for the same node, it is unnecessary to reload the Web UI when ordering a certificate for a different node. Signed-off-by: Filip Schauer --- Changes since v1: * Format the code to adhere to the style guide www/manager6/node/ACME.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/www/manager6/node/ACME.js b/www/manager6/node/ACME.js index 0642e7c5..9f1dabce 100644 --- a/www/manager6/node/ACME.js +++ b/www/manager6/node/ACME.js @@ -523,6 +523,10 @@ Ext.define('PVE.node.ACME', { orderFinished: function(success) { if (!success) return; + // reload only if the Web UI is open on the same node that the cert was ordered for + if (this.getView().nodename !== Proxmox.NodeName) { + return; + } var txt = gettext('pveproxy will be restarted with new certificates, please reload the GUI!'); Ext.getBody().mask(txt, ['pve-static-mask']); // reload after 10 seconds automatically -- 2.39.2