From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9D6EFAE80 for ; Tue, 8 Aug 2023 13:23:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7C39C8CC7 for ; Tue, 8 Aug 2023 13:23:17 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 8 Aug 2023 13:23:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1355643770 for ; Tue, 8 Aug 2023 13:23:16 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 8 Aug 2023 13:23:12 +0200 Message-Id: <20230808112312.64667-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230808112312.64667-1-f.ebner@proxmox.com> References: <20230808112312.64667-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.053 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [rados.pm] Subject: [pve-devel] [PATCH librados2-perl 3/3] use POSIX::_exit instead of exit in forked child X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Aug 2023 11:23:17 -0000 This avoids calling the END blocks and destructor routines most of which have nothing to do with the fork, so it cannot be assumed to be safe to do from the fork. Move the call to pve_rados_shutdown from the destructor routine, which will not be called by the child anymore. Make sure the cleanup is also done when the worker dies. Signed-off-by: Fiona Ebner --- Better viewed with -w PVE/RADOS.pm | 38 +++++++++++++++++++++----------------- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/PVE/RADOS.pm b/PVE/RADOS.pm index 41b9c39..f09d890 100644 --- a/PVE/RADOS.pm +++ b/PVE/RADOS.pm @@ -7,6 +7,7 @@ use warnings; use Carp; use JSON; +use POSIX; use Socket; use PVE::Tools; @@ -195,24 +196,30 @@ sub new { } else { # child $0 = 'pverados'; - PVE::INotify::inotify_close(); + eval { + PVE::INotify::inotify_close(); - if (my $atfork = $rpcenv->{atfork}) { - &$atfork(); - } + if (my $atfork = $rpcenv->{atfork}) { + &$atfork(); + } - # override signal handlers inherited from the parent - local $SIG{HUP} = $SIG{INT} = $SIG{QUIT} = $SIG{TERM} = sub { - exit(1); + # override signal handlers inherited from the parent + local $SIG{HUP} = $SIG{INT} = $SIG{QUIT} = $SIG{TERM} = sub { + pve_rados_shutdown($self->{conn}) if $self->{conn}; + POSIX::_exit(1); + }; + + # fixme: timeout? + + close $child; + + $self->pve_rados_work($parent, $timeout, %params); }; + my $err = $@; + warn $err if $err; - # fixme: timeout? - - close $child; - - $self->pve_rados_work($parent, $timeout, %params); - - exit(0); + pve_rados_shutdown($self->{conn}) if $self->{conn}; + POSIX::_exit($err ? 1 : 0); } return $self; @@ -233,9 +240,6 @@ sub DESTROY { #print "$$: DESTROY WAIT0\n"; &$kill_worker($self); #print "$$: DESTROY WAIT\n"; - } else { - #print "$$: DESTROY SHUTDOWN\n"; - pve_rados_shutdown($self->{conn}) if $self->{conn}; } } -- 2.39.2