From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EB2868F06 for ; Tue, 1 Aug 2023 10:43:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CF519BA1F for ; Tue, 1 Aug 2023 10:42:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 1 Aug 2023 10:42:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 922A943902 for ; Tue, 1 Aug 2023 10:42:36 +0200 (CEST) From: Christian Ebner To: pve-devel@lists.proxmox.com Date: Tue, 1 Aug 2023 10:42:09 +0200 Message-Id: <20230801084209.20645-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.172 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pve7to8.pm] Subject: [pve-devel] [PATCH v2 stable-7 manager] pve7to8: Add check for dkms modules X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2023 08:43:08 -0000 ... and warn if at least one is present. Signed-off-by: Christian Ebner --- changes since v1: * do not use which to check for dkms, use exit code directly PVE/CLI/pve7to8.pm | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm index 5ba73837..b4b62255 100644 --- a/PVE/CLI/pve7to8.pm +++ b/PVE/CLI/pve7to8.pm @@ -1322,6 +1322,27 @@ sub check_bootloader { } } +sub check_dkms_modules { + log_info("Check for dkms modules..."); + + my $count; + my $set_count = sub { + $count = scalar @_; + }; + + my $exit_code = eval { + run_command(['dkms', 'status', '-k', '`uname -r`'], outfunc => $set_count, noerr => 1) + }; + + if ($exit_code != 0) { + log_skip("could not get dkms status"); + } elsif (!$count) { + log_pass("no dkms modules found"); + } else { + log_warn("dkms modules found, this might cause issues during upgrade."); + } +} + sub check_misc { print_header("MISCELLANEOUS CHECKS"); my $ssh_config = eval { PVE::Tools::file_get_contents('/root/.ssh/config') }; @@ -1423,6 +1444,7 @@ sub check_misc { check_apt_repos(); check_nvidia_vgpu_service(); check_bootloader(); + check_dkms_modules(); } my sub colored_if { -- 2.39.2