From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 873918971 for ; Fri, 28 Jul 2023 15:29:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 69ECC15F59 for ; Fri, 28 Jul 2023 15:29:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 28 Jul 2023 15:29:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 944C741F1E for ; Fri, 28 Jul 2023 15:29:05 +0200 (CEST) From: Alexander Zeidler To: pve-devel@lists.proxmox.com Date: Fri, 28 Jul 2023 15:28:57 +0200 Message-Id: <20230728132858.98806-4-a.zeidler@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230728132858.98806-1-a.zeidler@proxmox.com> References: <20230728132858.98806-1-a.zeidler@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [common.pm] Subject: [pve-devel] [PATCH v4 guest-common 3/4] fix #3069: vzdump: schema: add 'pbs-entries-max' property X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jul 2023 13:29:36 -0000 configuring pbs-entries-max can avoid failing backups due to a high amount of files in folders where a folder exclusion is not possible Signed-off-by: Alexander Zeidler --- Changes since v3: Apply Fiona's comments: * simplify description Changes since v2: Apply Fiona's comments: * rephrase description * fix dot style nit Changes since v1: * improve description * move description to 'performance' section * remove arrow alignment src/PVE/VZDump/Common.pm | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm index 31e9fdb..be605af 100644 --- a/src/PVE/VZDump/Common.pm +++ b/src/PVE/VZDump/Common.pm @@ -88,6 +88,15 @@ PVE::JSONSchema::register_format('backup-performance', { default => 16, optional => 1, }, + 'pbs-entries-max' => { + description => "Applies to container backups sent to PBS. Limits the number of entries " + ."allowed in memory at a given time to avoid unintended OOM situations. Increase it to " + ."enable backups of containers with a large amount of files.", + type => 'integer', + minimum => 1, + default => 1048576, + optional => 1, + }, }); my $confdesc = { -- 2.39.2