From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 382AE85BC for ; Thu, 27 Jul 2023 12:39:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1B357A214 for ; Thu, 27 Jul 2023 12:39:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 27 Jul 2023 12:39:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 791DD40E83 for ; Thu, 27 Jul 2023 12:39:00 +0200 (CEST) From: Friedrich Weber To: pve-devel@lists.proxmox.com Date: Thu, 27 Jul 2023 12:37:47 +0200 Message-Id: <20230727103747.106574-4-f.weber@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230727103747.106574-1-f.weber@proxmox.com> References: <20230727103747.106574-1-f.weber@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.183 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [RFC common 3/3] network: recognize interfaces matching `c*` as physical NICs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jul 2023 10:39:31 -0000 Users can use systemd link files to assign meaningful interface names to physical NICs. However, so far PVE only recognizes interface names `ethN`, `en*` and `ib*` as physical NICs. NICs not matching these patterns cannot be configured via the GUI (their type is "Unknown"). To allow users to choose meaningful interface names and still configure these NICs via the GUI, recognize interfaces matching `c*` (for "custom") as physical NICs. Suggested-by: Aaron Lauterer Signed-off-by: Friedrich Weber --- src/PVE/Network.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm index a4f5ba9..02918a3 100644 --- a/src/PVE/Network.pm +++ b/src/PVE/Network.pm @@ -17,7 +17,7 @@ use Socket qw(NI_NUMERICHOST NI_NUMERICSERV); # host network related utility functions -our $PHYSICAL_NIC_RE = qr/(?:eth\d+|en[^:.]+|ib[^:.]+)/; +our $PHYSICAL_NIC_RE = qr/(?:eth\d+|en[^:.]+|ib[^:.]+|c[^:.]+)/; our $ipv4_reverse_mask = [ '0.0.0.0', -- 2.39.2