From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 923428347 for ; Thu, 27 Jul 2023 10:38:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 738F7841C for ; Thu, 27 Jul 2023 10:38:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 27 Jul 2023 10:38:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A51F840CFB for ; Thu, 27 Jul 2023 10:38:13 +0200 (CEST) From: Alexander Zeidler To: pve-devel@lists.proxmox.com Date: Thu, 27 Jul 2023 10:37:55 +0200 Message-Id: <20230727083759.19001-2-a.zeidler@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230727083759.19001-1-a.zeidler@proxmox.com> References: <20230727083759.19001-1-a.zeidler@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v3 manager/container/guest-common/docs 1/5] api: backup: refactor backup permission check X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jul 2023 08:38:14 -0000 Alter style to make the parameter check more concise Signed-off-by: Alexander Zeidler --- Changes since v2: * none Changes since v1: Apply Fiona's comments: * shorten permission check PVE/API2/Backup.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm index 45eb47e2..70753c2e 100644 --- a/PVE/API2/Backup.pm +++ b/PVE/API2/Backup.pm @@ -49,7 +49,7 @@ sub assert_param_permission_common { raise_param_exc({ $key => "Only root may set this option."}) if exists $param->{$key}; } - if (defined($param->{bwlimit}) || defined($param->{ionice}) || defined($param->{performance})) { + if (grep { defined($param->{$_}) } qw(bwlimit ionice performance)) { $rpcenv->check($user, "/", [ 'Sys.Modify' ]); } } -- 2.39.2