From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 92F7D80EE for ; Wed, 26 Jul 2023 16:04:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 78DE4272 for ; Wed, 26 Jul 2023 16:04:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 26 Jul 2023 16:04:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D52A545A63 for ; Wed, 26 Jul 2023 16:04:18 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Wed, 26 Jul 2023 16:03:54 +0200 Message-ID: <20230726140406.1048552-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [main.rs, mod.rs] Subject: [pve-devel] [PATCH installer 0/7] refactor; improve installation progress X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jul 2023 14:04:19 -0000 First 5 patches splits out the gigantic install progress dialog into its own module; then applying some divide-and-conquer to make it more readable and get the inner >150 lines closure down to a more maintainable state. Patch 6 does some code de-duplication for the low-lever installer. Patch 7 improves the auto-reboot message/UX by counting down the timeout, to match its GUI counterpart. Christoph Heiss (7): tui: move install progress dialog into own view module tui: install progress: split out low-level installer spawing into own function tui: install progress: split out reboot handling into own function tui: install progress: split out prompt logic into own function tui: install progress: handle errors in ui message loop more gracefully low-level: avoid open-coding config reading, parsing and merging low-level, tui: count down auto-reboot timeout proxmox-low-level-installer | 70 +++-- proxmox-tui-installer/src/main.rs | 235 +-------------- .../src/views/install_progress.rs | 275 ++++++++++++++++++ proxmox-tui-installer/src/views/mod.rs | 3 + 4 files changed, 318 insertions(+), 265 deletions(-) create mode 100644 proxmox-tui-installer/src/views/install_progress.rs -- 2.41.0