From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 09868F9B1 for ; Mon, 24 Jul 2023 11:04:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C6A4FBD79 for ; Mon, 24 Jul 2023 11:04:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 24 Jul 2023 11:04:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9546443A8A for ; Mon, 24 Jul 2023 11:04:20 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Mon, 24 Jul 2023 11:03:45 +0200 Message-ID: <20230724090408.221672-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH common/access-control v2 0/5] improve LDAP DN and bind creds checking on creation/change X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jul 2023 09:04:53 -0000 tl;dr implements the result of the discussion in [0]. First, this removes the dreaded LDAP DN regex, replacing it instead with a proper schema format, which does validation using Net::LDAP::Util::canonical_dn(). Further, upon saving a LDAP realm in the UI, it tries to connect & bind using the provided credentials, providing the user with immediate feedback whether they are valid or not. The same approach is already implemented in PBS [1]. Changes were tested against slapd 2.5.13+dfsg-5. [0] https://lists.proxmox.com/pipermail/pve-devel/2023-May/056839.html [1] https://git.proxmox.com/?p=proxmox-backup.git;a=commitdiff;h=5210f3b5 v1: https://lists.proxmox.com/pipermail/pve-devel/2023-July/058274.html Notable changes v1 -> v2: * Fixed updating a LDAP realm via raw API/pveum/pvesh (see #5) pve-common: Christoph Heiss (3): schema: add `ldap-dn` format for validating LDAP distinguished names test: add test cases for new 'ldap-dn' schema format ldap: handle errors explicitly everywhere instead of simply `die`ing debian/control | 2 ++ src/PVE/JSONSchema.pm | 12 +++++++++ src/PVE/LDAP.pm | 11 ++++---- test/Makefile | 1 + test/ldap_dn_format_test.pl | 54 +++++++++++++++++++++++++++++++++++++ 5 files changed, 75 insertions(+), 5 deletions(-) pve-access-control: Christoph Heiss (2): ldap: validate LDAP DNs using the `ldap-dn` schema format ldap: check bind credentials with LDAP directory directly on change src/PVE/API2/Domains.pm | 7 +++++-- src/PVE/Auth/LDAP.pm | 28 ++++++++++++++++------------ 2 files changed, 21 insertions(+), 14 deletions(-) -- 2.41.0