From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7CDEEF2FA for ; Thu, 20 Jul 2023 16:50:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5C290165C9 for ; Thu, 20 Jul 2023 16:50:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 20 Jul 2023 16:50:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AD67841E35 for ; Thu, 20 Jul 2023 16:50:45 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Thu, 20 Jul 2023 16:48:47 +0200 Message-ID: <20230720145000.418783-3-c.heiss@proxmox.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH access-control] api: domains: fix setting only the realm authentication password X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jul 2023 14:50:46 -0000 Previously, if one tried to only update e.g. the bind password for an LDAP realm, it would fail with an rather unhelpful error message: # pveum realm modify ldap -password foo update auth server failed: no options specified The root cause was that the `password` parameter was removed early from the parameter object, which than would fail the check whether it is empty or not. Thus, additionally check if only `password` was specified and if so, allow it. Reported-by: Friedrich Weber Signed-off-by: Christoph Heiss --- src/PVE/API2/Domains.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/API2/Domains.pm b/src/PVE/API2/Domains.pm index aa8e716..9332aa7 100644 --- a/src/PVE/API2/Domains.pm +++ b/src/PVE/API2/Domains.pm @@ -203,7 +203,8 @@ __PACKAGE__->register_method ({ if !$ids->{$realm}; my $delete_str = extract_param($param, 'delete'); - die "no options specified\n" if !$delete_str && !scalar(keys %$param); + die "no options specified\n" + if !$delete_str && !scalar(keys %$param) && !defined($password); my $delete_pw = 0; foreach my $opt (PVE::Tools::split_list($delete_str)) { -- 2.41.0