From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C0EABF0BF for ; Thu, 20 Jul 2023 16:33:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 39F0814947 for ; Thu, 20 Jul 2023 16:33:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 20 Jul 2023 16:33:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D089341EEB for ; Thu, 20 Jul 2023 16:33:06 +0200 (CEST) From: Lukas Wagner To: pve-devel@lists.proxmox.com Date: Thu, 20 Jul 2023 16:31:51 +0200 Message-Id: <20230720143236.652292-25-l.wagner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230720143236.652292-1-l.wagner@proxmox.com> References: <20230720143236.652292-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.096 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v4 proxmox 24/69] notify: additional logging when sending a notification X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jul 2023 14:33:42 -0000 Signed-off-by: Lukas Wagner --- proxmox-notify/src/lib.rs | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/proxmox-notify/src/lib.rs b/proxmox-notify/src/lib.rs index 0059e44b..6a52db06 100644 --- a/proxmox-notify/src/lib.rs +++ b/proxmox-notify/src/lib.rs @@ -305,9 +305,12 @@ impl Bus { if let Some(group) = self.groups.get(endpoint_or_group) { if !Bus::check_filter(&mut filter_matcher, group.filter.as_deref()) { + log::info!("skipped target '{endpoint_or_group}', filter did not match"); return; } + log::info!("target '{endpoint_or_group}' is a group, notifying all members..."); + for endpoint in &group.endpoint { self.send_via_single_endpoint(endpoint, notification, &mut filter_matcher); } @@ -339,19 +342,23 @@ impl Bus { filter_matcher: &mut FilterMatcher, ) { if let Some(endpoint) = self.endpoints.get(endpoint) { + let name = endpoint.name(); if !Bus::check_filter(filter_matcher, endpoint.filter()) { + log::info!("skipped target '{name}', filter did not match"); return; } - if let Err(e) = endpoint.send(notification) { - // Only log on errors, do not propagate fail to the caller. - log::error!( - "could not notify via target `{name}`: {e}", - name = endpoint.name() - ); + match endpoint.send(notification) { + Ok(_) => { + log::info!("notified via target `{name}`"); + } + Err(e) => { + // Only log on errors, do not propagate fail to the caller. + log::error!("could not notify via target `{name}`: {e}"); + } } } else { - log::error!("could not notify via endpoint '{endpoint}', it does not exist"); + log::error!("could not notify via target '{endpoint}', it does not exist"); } } -- 2.39.2