From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7AA62E8DE for ; Wed, 19 Jul 2023 14:11:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5CAB06CD9 for ; Wed, 19 Jul 2023 14:11:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 19 Jul 2023 14:11:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B2F834101A for ; Wed, 19 Jul 2023 14:11:13 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 19 Jul 2023 14:11:12 +0200 Message-Id: <20230719121112.229074-5-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230719121112.229074-1-d.csapak@proxmox.com> References: <20230719121112.229074-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager 3/3] ui: don't set the default value of combogrids to [] X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2023 12:11:48 -0000 the combogrid sets the default itself correctly Signed-off-by: Dominik Csapak --- depends on the widget-toolkit patch www/manager6/form/NodeSelector.js | 5 +---- www/manager6/ha/GroupSelector.js | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/www/manager6/form/NodeSelector.js b/www/manager6/form/NodeSelector.js index c3e3da31..bc282287 100644 --- a/www/manager6/form/NodeSelector.js +++ b/www/manager6/form/NodeSelector.js @@ -12,10 +12,7 @@ Ext.define('PVE.form.NodeSelector', { // only allow those nodes (array) allowedNodes: undefined, - // set default value to empty array, else it inits it with - // null and after the store load it is an empty array, - // triggering dirtychange - value: [], + valueField: 'node', displayField: 'node', store: { diff --git a/www/manager6/ha/GroupSelector.js b/www/manager6/ha/GroupSelector.js index 61ab0c03..1823472f 100644 --- a/www/manager6/ha/GroupSelector.js +++ b/www/manager6/ha/GroupSelector.js @@ -2,7 +2,6 @@ Ext.define('PVE.ha.GroupSelector', { extend: 'Proxmox.form.ComboGrid', alias: ['widget.pveHAGroupSelector'], - value: [], autoSelect: false, valueField: 'group', displayField: 'group', -- 2.30.2