From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 52B9BE94D for ; Wed, 19 Jul 2023 14:11:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 34AC86D02 for ; Wed, 19 Jul 2023 14:11:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 19 Jul 2023 14:11:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 88B7C41026 for ; Wed, 19 Jul 2023 14:11:13 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 19 Jul 2023 14:11:09 +0200 Message-Id: <20230719121112.229074-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230719121112.229074-1-d.csapak@proxmox.com> References: <20230719121112.229074-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH widget-toolkit 1/1] combogrid: initialze value with [] by default X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2023 12:11:48 -0000 we have to initialize the value of a combogrid to something (else extjs does not initialize everything in the object *sometimes* for yet unknown reasons), but the empty string is wrong. we already have at least two places where we set the default value to [] (namely NodeSelector and ha GroupSelector) with the comment: // set default value to empty array, else it inits it with // null and after the store load it is an empty array, // triggering dirtychange so it makes sense to always set it to that by default. This only ever is relevant when the combogrid has `allowBlank: true`, since if it does not it's either invalid (and thus "dirty") or it has a selected value anyway this should make the manual setting of value: [], unnecessary in the child classes. We can even remove it direcly in the NetworkSelector. Signed-off-by: Dominik Csapak --- src/form/ComboGrid.js | 2 +- src/form/NetworkSelector.js | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/form/ComboGrid.js b/src/form/ComboGrid.js index 55dee7e..6338a3a 100644 --- a/src/form/ComboGrid.js +++ b/src/form/ComboGrid.js @@ -400,7 +400,7 @@ Ext.define('Proxmox.form.ComboGrid', { matchFieldWidth: false, }); - Ext.applyIf(me, { value: '' }); // hack: avoid ExtJS validate() bug + Ext.applyIf(me, { value: [] }); // hack: avoid ExtJS validate() bug Ext.applyIf(me.listConfig, { width: 400 }); diff --git a/src/form/NetworkSelector.js b/src/form/NetworkSelector.js index 86d394d..30a1cd4 100644 --- a/src/form/NetworkSelector.js +++ b/src/form/NetworkSelector.js @@ -45,10 +45,6 @@ Ext.define('Proxmox.form.NetworkSelector', { networkSelectorStore.load(); } }, - // set default value to empty array, else it inits it with - // null and after the store load it is an empty array, - // triggering dirtychange - value: [], valueField: 'cidr', displayField: 'cidr', store: { -- 2.30.2