From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1C136E8D8 for ; Wed, 19 Jul 2023 14:11:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 042396D01 for ; Wed, 19 Jul 2023 14:11:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 19 Jul 2023 14:11:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7E09941023 for ; Wed, 19 Jul 2023 14:11:13 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 19 Jul 2023 14:11:08 +0200 Message-Id: <20230719121112.229074-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH widget-toolkit/manager] improve combogrid default value handling X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2023 12:11:18 -0000 the default value for combogrids is '', but we often need to set it to [], to avoid issues with dirty tracking. Fix this by setting it to [] by default, making it unnecessary to carry the workaround + comment around in child classes. the first patch of pve-manager is a bit unrelated but popped up during development (can be applied independently) the second patch of pve-manager is also a bit independent, but it fixes wrong dirty tracking in the firewall rule edit window iff the widget toolkit patch is also present the third manager patch depends on the widget toolkit patch proxmox-widget-toolkit: Dominik Csapak (1): combogrid: initialze value with [] by default src/form/ComboGrid.js | 2 +- src/form/NetworkSelector.js | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) pve-manager: Dominik Csapak (3): ui: ipset: make ip/cidr required ui: don't set the default value of combogrids to '' ui: don't set the default value of combogrids to [] www/manager6/form/NodeSelector.js | 5 +---- www/manager6/grid/FirewallRules.js | 2 -- www/manager6/ha/GroupSelector.js | 1 - www/manager6/panel/IPSet.js | 2 +- 4 files changed, 2 insertions(+), 8 deletions(-) -- 2.30.2