From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7AB27D299 for ; Thu, 13 Jul 2023 11:49:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4822837A3F for ; Thu, 13 Jul 2023 11:49:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 13 Jul 2023 11:49:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D7C3540883 for ; Thu, 13 Jul 2023 11:49:47 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Thu, 13 Jul 2023 11:49:31 +0200 Message-ID: <20230713094941.475486-8-c.heiss@proxmox.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230713094941.475486-1-c.heiss@proxmox.com> References: <20230713094941.475486-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer 7/7] tui: add tests for RAID setup checks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jul 2023 09:49:50 -0000 Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/views/bootdisk.rs | 143 ++++++++++++++++++++ 1 file changed, 143 insertions(+) diff --git a/proxmox-tui-installer/src/views/bootdisk.rs b/proxmox-tui-installer/src/views/bootdisk.rs index 9056323..8303cd7 100644 --- a/proxmox-tui-installer/src/views/bootdisk.rs +++ b/proxmox-tui-installer/src/views/bootdisk.rs @@ -714,3 +714,146 @@ fn check_btrfs_raid_config(level: BtrfsRaidLevel, disks: &[Disk]) -> Result<(), Ok(()) } + +#[cfg(test)] +mod tests { + use std::collections::HashMap; + + use super::*; + use crate::setup::{Dns, NetworkInfo}; + + fn dummy_disk(index: usize) -> Disk { + Disk { + index: index.to_string(), + path: format!("/dev/dummy{index}"), + model: Some("Dummy disk".to_owned()), + size: 1024. * 1024. * 1024. * 8., + block_size: 512, + } + } + + fn dummy_disks(num: usize) -> Vec { + (0..num).map(dummy_disk).collect() + } + + fn dummy_runinfo(boot_type: BootType) -> RuntimeInfo { + RuntimeInfo { + boot_type, + country: Some("at".to_owned()), + disks: dummy_disks(4), + network: NetworkInfo { + dns: Dns { + domain: None, + dns: vec![], + }, + routes: None, + interfaces: HashMap::new(), + }, + total_memory: 1024 * 1024 * 1024 * 64, + } + } + + #[test] + fn duplicate_disks() { + assert!(check_for_duplicate_disks(&dummy_disks(2)).is_ok()); + assert_eq!( + check_for_duplicate_disks(&[ + dummy_disk(0), + dummy_disk(1), + dummy_disk(2), + dummy_disk(2), + dummy_disk(3), + ]), + Err(&dummy_disk(2)), + ); + } + + #[test] + fn raid_min_disks() { + let disks = dummy_disks(10); + + assert!(check_raid_min_disks(&disks[..1], 2).is_err()); + assert!(check_raid_min_disks(&disks[..1], 1).is_ok()); + assert!(check_raid_min_disks(&disks, 1).is_ok()); + } + + #[test] + fn btrfs_raid() { + let disks = dummy_disks(10); + + assert!(check_btrfs_raid_config(BtrfsRaidLevel::Raid0, &[]).is_err()); + assert!(check_btrfs_raid_config(BtrfsRaidLevel::Raid0, &disks[..1]).is_ok()); + assert!(check_btrfs_raid_config(BtrfsRaidLevel::Raid0, &disks).is_ok()); + + assert!(check_btrfs_raid_config(BtrfsRaidLevel::Raid1, &[]).is_err()); + assert!(check_btrfs_raid_config(BtrfsRaidLevel::Raid1, &disks[..1]).is_err()); + assert!(check_btrfs_raid_config(BtrfsRaidLevel::Raid1, &disks[..2]).is_ok()); + assert!(check_btrfs_raid_config(BtrfsRaidLevel::Raid1, &disks).is_ok()); + + assert!(check_btrfs_raid_config(BtrfsRaidLevel::Raid10, &[]).is_err()); + assert!(check_btrfs_raid_config(BtrfsRaidLevel::Raid10, &disks[..3]).is_err()); + assert!(check_btrfs_raid_config(BtrfsRaidLevel::Raid10, &disks[..4]).is_ok()); + assert!(check_btrfs_raid_config(BtrfsRaidLevel::Raid10, &disks).is_ok()); + } + + #[test] + fn zfs_raid_bios() { + let disks = dummy_disks(10); + let runinfo = dummy_runinfo(BootType::Bios); + + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid0, &[]).is_err()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid0, &disks[..1]).is_ok()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid0, &disks).is_ok()); + + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid1, &[]).is_err()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid1, &disks[..2]).is_ok()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid1, &disks).is_ok()); + + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid10, &[]).is_err()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid10, &dummy_disks(4)).is_ok()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid10, &disks).is_ok()); + + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::RaidZ, &[]).is_err()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::RaidZ, &disks[..2]).is_err()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::RaidZ, &disks[..3]).is_ok()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::RaidZ, &disks).is_ok()); + + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::RaidZ2, &[]).is_err()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::RaidZ2, &disks[..3]).is_err()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::RaidZ2, &disks[..4]).is_ok()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::RaidZ2, &disks).is_ok()); + + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::RaidZ3, &[]).is_err()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::RaidZ3, &disks[..4]).is_err()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::RaidZ3, &disks[..5]).is_ok()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::RaidZ3, &disks).is_ok()); + + for i in 0..10 { + let mut disks = dummy_disks(10); + disks[i].block_size = 4096; + + // Must fail if /any/ of the disks are 4Kn + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid0, &disks).is_err()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid1, &disks).is_err()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid10, &disks).is_err()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::RaidZ, &disks).is_err()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::RaidZ2, &disks).is_err()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::RaidZ3, &disks).is_err()); + } + } + + #[test] + fn zfs_raid_efi() { + let disks = dummy_disks(10); + let runinfo = dummy_runinfo(BootType::Efi); + + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid0, &disks[..1]).is_ok()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid0, &disks).is_ok()); + + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid1, &disks[..2]).is_ok()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid1, &disks).is_ok()); + + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid10, &dummy_disks(4)).is_ok()); + assert!(check_zfs_raid_config(&runinfo, ZfsRaidLevel::Raid10, &disks).is_ok()); + } +} -- 2.41.0