From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <c.heiss@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 413E0D1FC for <pve-devel@lists.proxmox.com>; Thu, 13 Jul 2023 11:49:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 22AA3378D4 for <pve-devel@lists.proxmox.com>; Thu, 13 Jul 2023 11:49:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Thu, 13 Jul 2023 11:49:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 598DE4084C for <pve-devel@lists.proxmox.com>; Thu, 13 Jul 2023 11:49:47 +0200 (CEST) From: Christoph Heiss <c.heiss@proxmox.com> To: pve-devel@lists.proxmox.com Date: Thu, 13 Jul 2023 11:49:24 +0200 Message-ID: <20230713094941.475486-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [setup.rs, bootdisk.rs, options.rs] Subject: [pve-devel] [PATCH installer 0/7] tui: add ZFS/Btrfs RAID setup checks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 13 Jul 2023 09:49:48 -0000 This introduces the same checks when creating a RAID setup for ZFS and Btrfs as in the GUI installer. The main benefit is that the user now gets an error before the setup dialog can even be closed, instead of during the install process. Patch #1, #2 and #3 are some cleanups/fixes for things I noticed along the way, #4 and #5 are prepatory patches. #6 then implements the actual functionality. Additionally, #7 contains unit tests for all the logic code paths that were added, to ensure this cannot be accidentally be regressed. pve-installer: Christoph Heiss (7): gitignore: add cd-info.test tui: fix small typo in error message tui: simplify duplicate disk checking logic tui: deserialize boot type and disk blocksize from runtime env info tui: improve bootdisk dialog error handling tui: add RAID setup checks for ZFS/Btrfs tui: add tests for RAID setup checks .gitignore | 1 + proxmox-tui-installer/src/options.rs | 1 + proxmox-tui-installer/src/setup.rs | 15 +- proxmox-tui-installer/src/views/bootdisk.rs | 369 ++++++++++++++++++-- 4 files changed, 347 insertions(+), 39 deletions(-) -- 2.41.0