From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8F2FCC105 for ; Wed, 5 Jul 2023 16:38:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 71A5B35F30 for ; Wed, 5 Jul 2023 16:38:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 5 Jul 2023 16:38:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6CA1E45990 for ; Wed, 5 Jul 2023 16:38:26 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Wed, 5 Jul 2023 16:38:14 +0200 Message-ID: <20230705143818.1359775-1-c.heiss@proxmox.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm, qemuserver.pm, zones.pm, proxmox.com] Subject: [pve-devel] [PATCH network/container/qemu-server v2 0/3] drop unused `firewall` argument to {add, del}_bridge_fdb() X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jul 2023 14:38:58 -0000 While working on this code, I noticed that the `firewall` argument is never used (nor even declared) [0] in both PVE::Network::{add,del}_bridge_fdb(). Thus drop it everywhere and avoid needlessly passing around things which are never used anyway. Did some quick smoke-testing and everything kept working fine, but as there are really no functional changes, this should not effect anything. [ Basically just a re-spin of [1], just refreshed all patches such that they apply cleanly again. No actual changes between v1 and v2. ] [0] https://git.proxmox.com/?p=pve-common.git;a=blob;f=src/PVE/Network.pm;h=a4f5ba96;hb=HEAD#l299 [1] https://lists.proxmox.com/pipermail/pve-devel/2023-March/055970.html pve-network: Christoph Heiss (1): sdn: zones: drop unused `firewall` argument to {add, del}_bridge_fdb() src/PVE/Network/SDN/Zones.pm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) pve-container: Christoph Heiss (1): net: drop unused `firewall` argument to add_bridge_fdb() src/PVE/LXC.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) qemu-server: Christoph Heiss (1): net: drop unused `firewall` argument to {add, del}_bridge_fdb() PVE/QemuServer.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.39.2