From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C6F8CBE90 for ; Tue, 4 Jul 2023 15:53:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AD0E329E2F for ; Tue, 4 Jul 2023 15:53:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 4 Jul 2023 15:53:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BE25843D7F for ; Tue, 4 Jul 2023 15:53:18 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Tue, 4 Jul 2023 15:53:18 +0200 Message-Id: <20230704135318.3278928-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230704135318.3278928-1-d.csapak@proxmox.com> References: <20230704135318.3278928-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH proxmox-login-manager 2/2] tfa: allow closing tfa form X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jul 2023 13:53:50 -0000 abort the login when the form returns null. This happens if the user presses 'X' in the tfa form. Signed-off-by: Dominik Csapak --- lib/proxmox_login_form.dart | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart index dbc912a..861947d 100644 --- a/lib/proxmox_login_form.dart +++ b/lib/proxmox_login_form.dart @@ -433,11 +433,21 @@ class _ProxmoxLoginPageState extends State { if (client.credentials.tfa != null && client.credentials.tfa!.kinds().length > 0) { - client = await Navigator.of(context).push(MaterialPageRoute( + ProxmoxApiClient? tfaclient = + await Navigator.of(context).push(MaterialPageRoute( builder: (context) => ProxmoxTfaForm( apiClient: client, ), )); + + if (tfaclient != null) { + client = tfaclient; + } else { + setState(() { + _progressModel.inProgress -= 1; + }); + return; + } } final status = await client.getClusterStatus(); -- 2.30.2