From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C028EBE5D for ; Tue, 4 Jul 2023 11:45:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A32CC27897 for ; Tue, 4 Jul 2023 11:45:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 4 Jul 2023 11:45:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 01D4D43C65 for ; Tue, 4 Jul 2023 11:45:29 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pve-devel@lists.proxmox.com Date: Tue, 4 Jul 2023 11:45:06 +0200 Message-Id: <20230704094507.92567-4-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230704094507.92567-1-f.gruenbichler@proxmox.com> References: <20230704094507.92567-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH proxmox-widget-toolkit 1/1] apt: drop ChangeLogUrl X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jul 2023 09:45:59 -0000 it's not returned anymore by the corresponding backends, since fetching changelogs is now fully delegated to `apt`. Signed-off-by: Fabian Grünbichler --- Notes: could benefit from a Breaks on old versions of pve-manager/pmg-api , but not strictly required, it will simply allow attempting to fetch changelogs for packages where the backend already said there is none src/node/APT.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/node/APT.js b/src/node/APT.js index 739aaf3..231e866 100644 --- a/src/node/APT.js +++ b/src/node/APT.js @@ -2,7 +2,7 @@ Ext.define('apt-pkglist', { extend: 'Ext.data.Model', fields: [ 'Package', 'Title', 'Description', 'Section', 'Arch', 'Priority', 'Version', 'OldVersion', - 'ChangeLogUrl', 'Origin', + 'Origin', ], idProperty: 'Package', }); @@ -108,8 +108,8 @@ Ext.define('Proxmox.node.APT', { }); let show_changelog = function(rec) { - if (!rec?.data?.ChangeLogUrl || !rec?.data?.Package) { - console.debug('cannot show changelog, missing Package and/or ChangeLogUrl', rec); + if (!rec?.data?.Package) { + console.debug('cannot show changelog, missing Package', rec); return; } @@ -154,7 +154,7 @@ Ext.define('Proxmox.node.APT', { text: gettext('Changelog'), selModel: sm, disabled: true, - enableFn: rec => !!rec?.data?.ChangeLogUrl && !!rec?.data?.Package, + enableFn: rec => !!rec?.data?.Package, handler: (b, e, rec) => show_changelog(rec), }); -- 2.39.2