From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6A298AE3B for ; Wed, 28 Jun 2023 15:23:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 53F8F3F761 for ; Wed, 28 Jun 2023 15:23:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 28 Jun 2023 15:23:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E960E41B8B for ; Wed, 28 Jun 2023 15:23:18 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 28 Jun 2023 15:23:16 +0200 Message-Id: <20230628132316.90397-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pvecm.pm] Subject: [pve-devel] [PATCH cluster] pvecm: update comment about updatecerts timeout X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jun 2023 13:23:20 -0000 The call was moved by 84c3ab0 ("pve-cluster.service: move pvecm call to pveproxy.service") to pveproxy.service's ExecStartPre. Signed-off-by: Fiona Ebner --- src/PVE/CLI/pvecm.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PVE/CLI/pvecm.pm b/src/PVE/CLI/pvecm.pm index d816a0c..564dc99 100755 --- a/src/PVE/CLI/pvecm.pm +++ b/src/PVE/CLI/pvecm.pm @@ -572,9 +572,9 @@ __PACKAGE__->register_method ({ code => sub { my ($param) = @_; - # we get called by the pve-cluster.service ExecStartPost and as we do + # we get called by the pveproxy.service ExecStartPre and as we do # IO (on /etc/pve) which can hang (uninterruptedly D state). That'd be - # no-good for ExecStartPost as it fails the whole service in this case + # no-good for ExecStartPre as it fails the whole service in this case PVE::Tools::run_fork_with_timeout(30, sub { PVE::Cluster::Setup::updatecerts_and_ssh($param->@{qw(force silent)}); PVE::Cluster::prepare_observed_file_basedirs(); -- 2.30.2