From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 57ADB8FD2 for ; Fri, 23 Jun 2023 12:08:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 41919327F9 for ; Fri, 23 Jun 2023 12:08:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 23 Jun 2023 12:08:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E50ED4304D for ; Fri, 23 Jun 2023 12:08:13 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 23 Jun 2023 12:08:11 +0200 Message-Id: <20230623100811.28031-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH guest-common] replication: avoid passing removed storages to target X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2023 10:08:15 -0000 After removing a storage, replication states can still contain references to it, even if no volume references it anymore. If a storage does not exist in the storage configuration, the replication target runs into an error when preparing the job locally. This error prevents both running and removing the replication job. Fix it by not passing the invalid storage ID in the first place. Signed-off-by: Fiona Ebner --- src/PVE/Replication.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/PVE/Replication.pm b/src/PVE/Replication.pm index 469ca19..bd627e5 100644 --- a/src/PVE/Replication.pm +++ b/src/PVE/Replication.pm @@ -275,6 +275,9 @@ sub replicate { $logfunc->("guest => $guest_name, running => $running"); $logfunc->("volumes => " . join(',', @$sorted_volids)); + # filter out left-over non-existing/removed storages - avoids error on target + $state->{storeid_list} = [ grep { $storecfg->{ids}->{$_} } $state->{storeid_list}->@* ]; + if (my $remove_job = $jobcfg->{remove_job}) { $logfunc->("start job removal - mode '${remove_job}'"); -- 2.39.2