From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6E79E8FA2 for ; Fri, 23 Jun 2023 11:03:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4E6FC31220 for ; Fri, 23 Jun 2023 11:03:09 +0200 (CEST) Received: from bastionodiso.odiso.net (bastionodiso.odiso.net [185.151.191.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 23 Jun 2023 11:03:08 +0200 (CEST) Received: from kvmformation3.odiso.net (formationkvm3.odiso.net [10.3.94.12]) by bastionodiso.odiso.net (Postfix) with ESMTP id 25B287F8B; Fri, 23 Jun 2023 11:03:08 +0200 (CEST) Received: by kvmformation3.odiso.net (Postfix, from userid 0) id 0E8C83350C5; Fri, 23 Jun 2023 11:03:08 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Date: Fri, 23 Jun 2023 11:02:55 +0200 Message-Id: <20230623090258.284882-1-aderumier@odiso.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.036 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy HEADER_FROM_DIFFERENT_DOMAINS 0.25 From and EnvelopeFrom 2nd level mail domains are different KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [inotify.pm, proxmox.com] Subject: [pve-devel] [PATCH-SERIE ifupdown2/common] disable rx-vlan-filter on iface in vlan-aware-bridge X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2023 09:03:09 -0000 Hi, Some nics like mellanox connect-x or intel i40e don't work with vlan-aware-bridge when too many vlans are defined. Depend of the model, connectx-3 is limited to 64 vlans, connect-x4 to 128vlans https://forum.proxmox.com/threads/proxmox-7-and-mellanox-connectx4-and-vlan-aware-bridge.104926/#post-555269 i40e seem to throw errors like Jan 18 14:44:27 jupiter kernel: [ 145.060365] i40e 0000:3d:00.0: Error I40E_AQ_RC_ENOSPC, forcing overflow promiscuous on PF https://forum.proxmox.com/threads/error-i40e_aq_rc_enospc-forcing-overflow-promiscuous-on-pf.62875/ https://forum.proxmox.com/threads/proxmox-8-and-i40e-driver-kernel-6-2.129364/ rx-vlan-filter is only a protection to drop packets with unknown vlan at nic level. (not related to vlan offloading, where nic can support any number of vlan) When vlan-aware is enabled, bridge is already doing the vlan filtering, so it's pretty safe to disable it. (AFAIK, it was not enabled on proxmox 5, as I didn't have mellanox problem at this time) This patch serie add support to ifupdown2 to "rx-vlan-filter" and add ethtool as depend and rx-vlan-filter is added to /etc/network/interfaces on phys nic if the nic is port of vlan aware bridge. (or slave of bond port of vlan-aware-bridge) fix: https://bugzilla.proxmox.com/show_bug.cgi?id=2329 https://bugzilla.proxmox.com/show_bug.cgi?id=3893 (maybe they are other related bug reports) ifupdown2: Alexandre Derumier (2): add ethtool as depend patch: ethtool: add rx-vlan-filter support debian/control | 4 +- debian/patches/series | 1 + ...01-addons-ethtool-add-rx-vlan-filter.patch | 43 +++++++++++++++++++ ifupdown2 | 2 +- 4 files changed, 47 insertions(+), 3 deletions(-) create mode 100644 debian/patches/upstream/0001-addons-ethtool-add-rx-vlan-filter.patch pve-common: Alexandre Derumier (1): network_interfaces: disable rx-vlan-filter for physical interfaces ports of a vlan-aware bridge src/PVE/INotify.pm | 2 ++ 1 file changed, 2 insertions(+) -- 2.39.2