From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E12568EB7 for ; Fri, 23 Jun 2023 09:08:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C92512F639 for ; Fri, 23 Jun 2023 09:08:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 23 Jun 2023 09:08:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BFE6242D99 for ; Fri, 23 Jun 2023 09:08:48 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Fri, 23 Jun 2023 09:08:42 +0200 Message-Id: <20230623070847.1672322-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [defines.mk] Subject: [pve-devel] [PATCH eslint/manager/wt/pmg-gui/proxmox-backup v3] change eslint X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jun 2023 07:08:50 -0000 from 'eslint' to 'pve-eslint' to avoid a conflict with debians 'eslint' package which ships the same binary to avoid breakage, pull out the eslint binary into a make variable and use pve-eslint if it exists, and eslint otherwise changes from v2: * use $(shell command) instead of $(wildcard), thanks @thomas for the suggestions, this makes it shorter + we don't have to use the full path * added Suggested-by trailers changes from v1: * use $(ESLINT) * use $(wildcard) make builtin to check if pve-eslint exists, use eslint as fallback * introduce defines.mk in pmg-gui for ESLINT variable pve-eslint: Dominik Csapak (1): change binary name from 'eslint' to 'pve-eslint' debian/links | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) pve-manager: Dominik Csapak (1): try using 'pve-eslint' if it exists defines.mk | 2 ++ www/manager6/Makefile | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) proxmox-widget-toolkit: Dominik Csapak (1): try using 'pve-eslint' if it exists src/Makefile | 6 +++--- src/defines.mk | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) pmg-gui: Dominik Csapak (1): try using 'pve-eslint' if it exists defines.mk | 1 + js/Makefile | 6 ++++-- js/mobile/Makefile | 3 ++- 3 files changed, 7 insertions(+), 3 deletions(-) create mode 100644 defines.mk proxmox-backup: Dominik Csapak (1): try using 'pve-eslint' if it exists defines.mk | 1 + www/Makefile | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) -- 2.30.2