From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B745B8AFD for ; Thu, 22 Jun 2023 16:19:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9236927759 for ; Thu, 22 Jun 2023 16:18:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 22 Jun 2023 16:18:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9C6FB42B75 for ; Thu, 22 Jun 2023 16:18:37 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Thu, 22 Jun 2023 16:18:34 +0200 Message-Id: <20230622141834.57197-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230622141834.57197-1-f.ebner@proxmox.com> References: <20230622141834.57197-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer 2/2] always align rootdisk size to 4 MiB X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jun 2023 14:19:08 -0000 While this was already done in the $rest < 48 GiB cases, it wasn't yet done for the else branch and also not if $maxroot_mb was assigned, because of being smaller. Second and last step towards fixing an issue reported in the community forum [0] where using 250.00 hdsize, 250 maxroot and 0 minfree would fail. Turns out two extents would be missing because of lvcreate implicitly rounding up, one of them for the root LV (the one for metadata was already handled in the previous commit). [0]: https://forum.proxmox.com/threads/129320/post-566375 Signed-off-by: Fiona Ebner --- I think it'd be possible to drop the alignments in the branches now, but let's fix the issue for now and tackle improving/reworking the logic more for later. Proxmox/Install.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index c2c014d..25031f8 100644 --- a/Proxmox/Install.pm +++ b/Proxmox/Install.pm @@ -435,6 +435,7 @@ sub create_lvm_volumes { $rootsize_mb = $maxroot_mb if $rootsize_mb > $maxroot_mb; $rootsize = int($rootsize_mb * 1024); + $rootsize &= ~0xFFF; # align down to 4 MB boundaries $rest -= $rootsize; # in KB -- 2.39.2