From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B6FAA8AFC for ; Thu, 22 Jun 2023 16:19:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 90850276C4 for ; Thu, 22 Jun 2023 16:18:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 22 Jun 2023 16:18:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9A71442B74 for ; Thu, 22 Jun 2023 16:18:37 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Thu, 22 Jun 2023 16:18:33 +0200 Message-Id: <20230622141834.57197-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer 1/2] align metadatasize to 4 MiB X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jun 2023 14:19:08 -0000 First step towards fixing an issue reported in the community forum [0] where using 250.00 hdsize, 250 maxroot and 0 minfree would fail. Turns out two extents would be missing because of lvcreate implicitly rounding up, one of them for the metadata. [0]: https://forum.proxmox.com/threads/129320/post-566375 Signed-off-by: Fiona Ebner --- Proxmox/Install.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index 7970f83..c2c014d 100644 --- a/Proxmox/Install.pm +++ b/Proxmox/Install.pm @@ -469,9 +469,10 @@ sub create_lvm_volumes { die "unable to create root volume\n"; if ($datasize > 4 * 1024 * 1024) { - my $metadatasize = $datasize/100; # default 1% of data + my $metadatasize = int($datasize/100); # default 1% of data $metadatasize = 1024*1024 if $metadatasize < 1024*1024; # but at least 1G $metadatasize = 16*1024*1024 if $metadatasize > 16*1024*1024; # but at most 16G + $metadatasize &= ~0xFFF; # align down to 4 MB boundaries # otherwise the metadata is taken out of $minfree $datasize -= 2 * $metadatasize; -- 2.39.2