From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B38A68B4A for ; Thu, 22 Jun 2023 15:58:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8D91E27466 for ; Thu, 22 Jun 2023 15:57:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 22 Jun 2023 15:57:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CE9B742B73 for ; Thu, 22 Jun 2023 15:57:35 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Thu, 22 Jun 2023 15:57:13 +0200 Message-Id: <20230622135713.1326873-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.098 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer] fix space calculation for small disks for pve product X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jun 2023 13:58:06 -0000 The convoluted calculation logic in case the disks is 8GB leads to datasize becoming 16EiB further down: * after calculating and removing the rootsize from $rest, $rest becomes smaller than $space (which should be the minimal non-used space in the volume-group) - this leads to a negative value, which overflows in the `& ~0xFFF` opration. Signed-off-by: Stoiko Ivanov --- tested in a VM with an 8GB disk Proxmox/Install.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index 7970f83..28add10 100644 --- a/Proxmox/Install.pm +++ b/Proxmox/Install.pm @@ -425,7 +425,7 @@ sub create_lvm_volumes { my $rootsize_mb; if ($rest_mb < 12 * 1024) { # no point in wasting space, try to get us actually installed and align down to 4 MB - $rootsize_mb = ($rest_mb - 0.1) & ~3; + $rootsize_mb = ($rest_mb - 4) & ~3; } elsif ($rest_mb < 48 * 1024) { my $masked = int($rest_mb / 2) & ~3; # align down to 4 MB $rootsize_mb = $masked; -- 2.30.2