From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4361689B3 for ; Thu, 22 Jun 2023 11:56:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2368626B57 for ; Thu, 22 Jun 2023 11:56:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 22 Jun 2023 11:56:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 657F542A77 for ; Thu, 22 Jun 2023 11:56:20 +0200 (CEST) From: Christoph Heiss To: pve-devel@lists.proxmox.com Date: Thu, 22 Jun 2023 11:56:16 +0200 Message-Id: <20230622095617.671605-2-c.heiss@proxmox.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230622095617.671605-1-c.heiss@proxmox.com> References: <20230622095617.671605-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.077 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer 1/2] tui: wrap multi-disk selection in scrollable view X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jun 2023 09:56:21 -0000 If lots of disks are present and the available screen size is rather small, it might be impossible for users to properly set all disks as they want. Fix it by making the view scrollable. Signed-off-by: Christoph Heiss --- proxmox-tui-installer/src/views/bootdisk.rs | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/proxmox-tui-installer/src/views/bootdisk.rs b/proxmox-tui-installer/src/views/bootdisk.rs index 09e6803..775ffa4 100644 --- a/proxmox-tui-installer/src/views/bootdisk.rs +++ b/proxmox-tui-installer/src/views/bootdisk.rs @@ -2,7 +2,9 @@ use std::{cell::RefCell, marker::PhantomData, rc::Rc}; use cursive::{ view::{Nameable, Resizable, ViewWrapper}, - views::{Button, Dialog, DummyView, LinearLayout, NamedView, Panel, SelectView, TextView}, + views::{ + Button, Dialog, DummyView, LinearLayout, NamedView, Panel, ScrollView, SelectView, TextView, + }, Cursive, View, }; @@ -268,7 +270,7 @@ impl MultiDiskOptionsView { let disk_select_view = LinearLayout::vertical() .child(TextView::new("Disk setup").center()) .child(DummyView) - .child(disk_form); + .child(ScrollView::new(disk_form)); let options_view = LinearLayout::vertical() .child(TextView::new("Advanced options").center()) @@ -306,7 +308,8 @@ impl MultiDiskOptionsView { .get_child(0)? .downcast_ref::()? .get_child(2)? - .downcast_ref::()?; + .downcast_ref::>()? + .get_inner(); for i in 0..disk_form.len() { let disk = disk_form.get_value::>, _>(i)?; -- 2.40.1