From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5EC908647 for ; Wed, 21 Jun 2023 17:02:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3D6D71F949 for ; Wed, 21 Jun 2023 17:02:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 21 Jun 2023 17:02:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 904C342635 for ; Wed, 21 Jun 2023 17:02:08 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 21 Jun 2023 17:02:00 +0200 Message-Id: <20230621150201.100421-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pve7to8.pm] Subject: [pve-devel] [PATCH stable-7 manager 1/2] pve7to8: remove outdated warning about retention X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2023 15:02:09 -0000 It just talks about the default behavior since PVE 7. It's rather confusing to mention this, because the behavior doesn't change anymore in PVE 8. Signed-off-by: Fiona Ebner --- Intended for both master and stable-7. PVE/CLI/pve7to8.pm | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm index 6b51e98e..87dc1dc3 100644 --- a/PVE/CLI/pve7to8.pm +++ b/PVE/CLI/pve7to8.pm @@ -608,8 +608,6 @@ sub check_backup_retention_settings { my $pass = 1; - my $node_has_retention; - my $maxfiles_msg = "parameter 'maxfiles' is deprecated with PVE 7.x and will be removed in a " . "future version, use 'prune-backups' instead."; @@ -626,8 +624,6 @@ sub check_backup_retention_settings { $pass = 0; log_warn("$fn - $maxfiles_msg"); } - - $node_has_retention = defined($param->{maxfiles}) || defined($param->{'prune-backups'}); }; if (my $err = $@) { $pass = 0; @@ -643,15 +639,6 @@ sub check_backup_retention_settings { $pass = 0; log_warn("storage '$storeid' - $maxfiles_msg"); } - - next if !$scfg->{content}->{backup}; - next if defined($scfg->{maxfiles}) || defined($scfg->{'prune-backups'}); - next if $node_has_retention; - - log_info( - "storage '$storeid' - no backup retention settings defined - by default, since PVE 7.0" - ." it will no longer keep only the last backup, but all backups" - ); } eval { -- 2.39.2