From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2BB0A8608 for ; Wed, 21 Jun 2023 16:32:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 11E341F3FB for ; Wed, 21 Jun 2023 16:32:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 21 Jun 2023 16:32:54 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9AE6942618 for ; Wed, 21 Jun 2023 16:32:54 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Wed, 21 Jun 2023 16:32:26 +0200 Message-Id: <20230621143227.1510250-3-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230621143227.1510250-1-s.ivanov@proxmox.com> References: <20230621143227.1510250-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.099 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH 2/3] proxmox-boot: warn on missing systemd-boot package X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2023 14:32:56 -0000 With the shipping of systemd-boot as separate package, we cannot rely on `bootctl` being present in all systems (e.g. currently all systems upgraded from PVE 7 will not automatically pull systemd-boot in. This patch adds a check for existence + warning with an explanation to the only invocation of bootctl in the boot-tool codebase Signed-off-by: Stoiko Ivanov --- src/bin/proxmox-boot-tool | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool index d41f921..913b0f6 100755 --- a/src/bin/proxmox-boot-tool +++ b/src/bin/proxmox-boot-tool @@ -153,6 +153,12 @@ init_bootloader() { if [ -d /sys/firmware/efi ]; then echo "Installing systemd-boot.." mkdir -p "$esp_mp/$PMX_ESP_DIR" + if ! command -V bootctl >/dev/null 2>&1 ; + then + warn "E: bootctl is not available - make sure systemd-boot is installed" + exit 1 + fi + bootctl --graceful --path "$esp_mp" install echo "Configuring systemd-boot.." -- 2.30.2