From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7BD188595 for ; Wed, 21 Jun 2023 16:16:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D5891EAA1 for ; Wed, 21 Jun 2023 16:16:51 +0200 (CEST) Received: from lana.proxmox.com (unknown [94.136.29.99]) by firstgate.proxmox.com (Proxmox) with ESMTP for ; Wed, 21 Jun 2023 16:16:50 +0200 (CEST) Received: by lana.proxmox.com (Postfix, from userid 10043) id 407952C1027; Wed, 21 Jun 2023 16:16:50 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Wed, 21 Jun 2023 16:16:49 +0200 Message-Id: <20230621141649.1062567-1-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.418 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [utils.rs, mod.rs] Subject: [pve-devel] [PATCH pve-installer] tui: improve ipv6 handling X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2023 14:16:51 -0000 * fix detection of ipv6 addresses * change input for CIDR to allow integers up until 128 Signed-off-by: Stefan Hanreich --- proxmox-tui-installer/src/utils.rs | 2 +- proxmox-tui-installer/src/views/mod.rs | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/proxmox-tui-installer/src/utils.rs b/proxmox-tui-installer/src/utils.rs index c4b7c03..3245fac 100644 --- a/proxmox-tui-installer/src/utils.rs +++ b/proxmox-tui-installer/src/utils.rs @@ -65,7 +65,7 @@ impl CidrAddress { /// Returns `true` if this address is an IPv6 address, `false` otherwise. pub fn is_ipv6(&self) -> bool { - self.addr.is_ipv4() + self.addr.is_ipv6() } /// Returns only the mask part of the address. diff --git a/proxmox-tui-installer/src/views/mod.rs b/proxmox-tui-installer/src/views/mod.rs index 4160b8f..dc58043 100644 --- a/proxmox-tui-installer/src/views/mod.rs +++ b/proxmox-tui-installer/src/views/mod.rs @@ -387,10 +387,10 @@ impl CidrAddressEditView { fn mask_edit_view(content: usize) -> ResizedView { IntegerEditView::new() - .max_value(32) - .max_content_width(2) + .max_value(128) + .max_content_width(3) .content(content) - .fixed_width(3) + .fixed_width(4) } fn get_values(&self) -> Option { -- 2.39.2