From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 40AD68270 for ; Wed, 21 Jun 2023 11:57:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1F40C1AC87 for ; Wed, 21 Jun 2023 11:57:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 21 Jun 2023 11:57:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 450C042472 for ; Wed, 21 Jun 2023 11:57:43 +0200 (CEST) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Wed, 21 Jun 2023 11:57:42 +0200 Message-Id: <20230621095742.54009-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer] gui: make abort button unsensitive on last panel X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2023 09:57:44 -0000 It makes no sense from a UX point of view to abort an install that's already finished. Signed-off-by: Maximiliano Sandoval --- proxinstall | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/proxinstall b/proxinstall index 6d13892..bf88b31 100755 --- a/proxinstall +++ b/proxinstall @@ -213,6 +213,7 @@ sub create_main_window { $gtk_state->{next_btn} = $next_btn; $gtk_state->{progress_bar} = Gtk3::ProgressBar->new(); $gtk_state->{progress_status} = Gtk3::Label->new(''); + $gtk_state->{abort_btn} = $abort; Proxmox::UI::init_gtk($gtk_state, $iso_env); @@ -1522,6 +1523,10 @@ sub create_extract_view { return $raw_html; }; + # It does not make sense to Abort the install at this point, whether it + # succeded or failed makes no difference. + $gtk_state->{abort_btn}->set_sensitive(0); + if ($err) { Proxmox::UI::display_html("fail.htm"); # suppress "empty" error as we got some case where the user choose to abort on a prompt, -- 2.39.2