From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7CD288260 for ; Wed, 21 Jun 2023 10:55:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6144B1A0CC for ; Wed, 21 Jun 2023 10:55:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 21 Jun 2023 10:55:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AAC19423F7 for ; Wed, 21 Jun 2023 10:55:06 +0200 (CEST) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Wed, 21 Jun 2023 10:55:05 +0200 Message-Id: <20230621085505.28910-2-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230621085505.28910-1-m.sandoval@proxmox.com> References: <20230621085505.28910-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v2 installer 1/1] fix #4643: show a confirmation dialog when clicking abort X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2023 08:55:37 -0000 Note that unlike the rest of the file, we connect to the response signal instead of using Gtk3::Dialog->run, the reason is that run blocks the main loop used by GTK and this undesirable to the point where Gtk3::Dialog->run was removed for GTK 4. Signed-off-by: Maximiliano Sandoval --- proxinstall | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/proxinstall b/proxinstall index 6d13892..600d5a5 100755 --- a/proxinstall +++ b/proxinstall @@ -180,7 +180,19 @@ sub create_main_window { my $abort = Gtk3::Button->new('_Abort'); $abort->set_can_focus(0); $cmdbox->pack_start($abort, 0, 0, 10); - $abort->signal_connect(clicked => sub { app_quit(-1); }); + $abort->signal_connect(clicked => sub { + my $msg = 'Abort Installation'; + my $secondary_text = 'Are you sure you want to abort the installation?'; + my $dialog = Gtk3::MessageDialog->new($window, 'modal', 'question', 'yes-no', $msg); + $dialog->format_secondary_text($secondary_text); + $dialog->signal_connect(response => sub { + my ($dialog, $response) = @_; + + $dialog->close(); + app_quit(-1) if $response eq 'yes'; + }); + $dialog->present(); + }); my $vbox2 = Gtk3::Box->new('vertical', 0); $hbox->add($vbox2); -- 2.39.2