From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ED4CBA2D5E for ; Tue, 20 Jun 2023 17:46:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C6EBF37CE4 for ; Tue, 20 Jun 2023 17:46:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 20 Jun 2023 17:46:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6F08841E9A for ; Tue, 20 Jun 2023 17:46:09 +0200 (CEST) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Tue, 20 Jun 2023 17:46:08 +0200 Message-Id: <20230620154608.338825-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm] Subject: [pve-devel] [PATCH container] fix #4765: lxc: report cpu usage correctly X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2023 15:46:41 -0000 When running `pct status VMID` the variable $last_proc_vmid_stat->{$vmid} is not set and pct reports no cpu usage. We address this by computing the used cpu time over the total uptime of the container. Signed-off-by: Maximiliano Sandoval --- src/PVE/LXC.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm index a531ea5..17a7cd7 100644 --- a/src/PVE/LXC.pm +++ b/src/PVE/LXC.pm @@ -276,10 +276,13 @@ sub vmstatus { my $old = $last_proc_vmid_stat->{$vmid}; if (!$old) { + my $uptime_ms = $d->{uptime} * $cpucount * 1000.0; + $d->{cpu} = (($used_ms / $uptime_ms) * $cpucount) / $d->{cpus}; + $last_proc_vmid_stat->{$vmid} = { time => $cdtime, used => $used_ms, - cpu => 0, + cpu => $d->{cpu}, }; next; } -- 2.39.2