From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D4264A2AC4 for ; Tue, 20 Jun 2023 11:35:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AD5F332C8D for ; Tue, 20 Jun 2023 11:34:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 20 Jun 2023 11:34:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0877F40938 for ; Tue, 20 Jun 2023 11:34:32 +0200 (CEST) From: Maximiliano Sandoval To: pve-devel@lists.proxmox.com Date: Tue, 20 Jun 2023 11:34:31 +0200 Message-Id: <20230620093431.73772-1-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH installer] make harddisk options dialog modal X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2023 09:35:02 -0000 Modal dialogs block the user from interacting with the main window. We already do this with message dialogs so for consistency sake, we set the harddisk options dialog as modal. Note that one can see weird behaviors when interacting with the window behind the dialog in certain scenarios. Signed-off-by: Maximiliano Sandoval --- proxinstall | 2 ++ 1 file changed, 2 insertions(+) diff --git a/proxinstall b/proxinstall index fe0239f..f32abd2 100755 --- a/proxinstall +++ b/proxinstall @@ -2291,6 +2291,8 @@ sub create_hdoption_view { my $dialog = Gtk3::Dialog->new(); $dialog->set_title("Harddisk options"); + $dialog->set_modal(1); + $dialog->set_transient_for($window); $dialog->add_button("_OK", 1); -- 2.39.2