From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CD9FAA27CC for ; Mon, 19 Jun 2023 11:30:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9A7EB272ED for ; Mon, 19 Jun 2023 11:29:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 19 Jun 2023 11:29:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 05E87468FC for ; Mon, 19 Jun 2023 11:29:40 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Mon, 19 Jun 2023 11:29:35 +0200 Message-Id: <20230619092937.604628-9-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230619092937.604628-1-a.lauterer@proxmox.com> References: <20230619092937.604628-1-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.086 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v5 container 8/10] migration: only migrate volumes used by the guest X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2023 09:30:12 -0000 When scanning all configured storages for volumes belonging to the container, the migration could easily fail if a storage is not available, but enabled. That storage might not even be used by the container at all. By not doing that and only looking at the disk images referenced in the config, we can avoid that. We need to add additional steps for pending volumes with checks if they actually exist. Changing an existing mountpoint to a new volume will only create the volume on the next start of the container. The big change regarding behavior is that volumes not referenced in the container config will be ignored. They are already orphans that used to be migrated as well, but are now left where they are. Reviewed-by: Fiona Ebner Signed-off-by: Aaron Lauterer --- changes since v4: fixed last defined() style nit src/PVE/LXC/Migrate.pm | 42 ++++++++++++------------------------------ 1 file changed, 12 insertions(+), 30 deletions(-) diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm index ccf5157..3947227 100644 --- a/src/PVE/LXC/Migrate.pm +++ b/src/PVE/LXC/Migrate.pm @@ -195,6 +195,12 @@ sub phase1 { return if !$volid; + # check if volume exists, might be a pending new one + if ($volid =~ $PVE::LXC::NEW_DISK_RE) { + $self->log('info', "volume '$volid' does not exist (pending change?)"); + return; + } + my ($sid, $volname) = PVE::Storage::parse_volume_id($volid); # check if storage is available on source node @@ -256,42 +262,18 @@ sub phase1 { &$log_error($@, $volid) if $@; }; - # first unused / lost volumes owned by this container - my @sids = PVE::Storage::storage_ids($self->{storecfg}); - foreach my $storeid (@sids) { - my $scfg = PVE::Storage::storage_config($self->{storecfg}, $storeid); - next if $scfg->{shared} && !$remote; - next if !PVE::Storage::storage_check_enabled($self->{storecfg}, $storeid, undef, 1); - - # get list from PVE::Storage (for unreferenced volumes) - my $dl = PVE::Storage::vdisk_list($self->{storecfg}, $storeid, $vmid, undef, 'rootdir'); - - next if @{$dl->{$storeid}} == 0; - - # check if storage is available on target node - my $targetsid = PVE::JSONSchema::map_id($self->{opts}->{storagemap}, $storeid); - if (!$remote) { - my $target_scfg = PVE::Storage::storage_check_enabled($self->{storecfg}, $targetsid, $self->{node}); - - die "content type 'rootdir' is not available on storage '$targetsid'\n" - if !$target_scfg->{content}->{rootdir}; - } - - PVE::Storage::foreach_volid($dl, sub { - my ($volid, $sid, $volname) = @_; - - $volhash->{$volid}->{ref} = 'storage'; - $volhash->{$volid}->{targetsid} = $targetsid; - }); - } - - # then all volumes referenced in snapshots + # first all volumes referenced in snapshots foreach my $snapname (keys %{$conf->{snapshots}}) { &$test_volid($conf->{snapshots}->{$snapname}->{'vmstate'}, 0, undef) if defined($conf->{snapshots}->{$snapname}->{'vmstate'}); PVE::LXC::Config->foreach_volume($conf->{snapshots}->{$snapname}, $test_mp, $snapname); } + # then all pending volumes + if (defined($conf->{pending}) && $conf->{pending}->%*) { + PVE::LXC::Config->foreach_volume($conf->{pending}, $test_mp); + } + # finally all current volumes PVE::LXC::Config->foreach_volume_full($conf, { include_unused => 1 }, $test_mp); -- 2.39.2