From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D17E9A267E for ; Mon, 19 Jun 2023 11:14:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B45A426E1D for ; Mon, 19 Jun 2023 11:13:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 19 Jun 2023 11:13:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 95306468C8 for ; Mon, 19 Jun 2023 11:13:35 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 19 Jun 2023 11:13:31 +0200 Message-Id: <20230619091334.1715659-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230619091334.1715659-1-d.csapak@proxmox.com> References: <20230619091334.1715659-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager 2/5] ui: multi pci selector: reset the selection properly on nodename change X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2023 09:14:06 -0000 and mdev change. giving an empty array did not have the desired effect of resetting the selection, but giving no parameter at all does. this now also clears the selection when the mdev filter/config changed (was just forgotten) Signed-off-by: Dominik Csapak --- www/manager6/form/MultiPCISelector.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/www/manager6/form/MultiPCISelector.js b/www/manager6/form/MultiPCISelector.js index 99f9d50b..97241bb0 100644 --- a/www/manager6/form/MultiPCISelector.js +++ b/www/manager6/form/MultiPCISelector.js @@ -77,7 +77,7 @@ Ext.define('PVE.form.MultiPCISelector', { } me.suspendEvent('change'); - me.setSelection([]); + me.setSelection(); me.setSelection(recs); me.resumeEvent('change'); }, @@ -96,7 +96,7 @@ Ext.define('PVE.form.MultiPCISelector', { url: '/api2/json/nodes/' + me.nodename + '/hardware/pci?pci-class-blacklist=', }); - me.setSelection([]); + me.setSelection(); me.getStore().load({ callback: (recs, op, success) => me.addSlotRecords(recs, op, success), @@ -115,6 +115,7 @@ Ext.define('PVE.form.MultiPCISelector', { } else { me.getStore().removeFilter('mdev-filter'); } + me.setSelection(); }, // adds the virtual 'slot' records (e.g. '0000:01:00') to the store -- 2.30.2