From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 7BB71A2102
for <pve-devel@lists.proxmox.com>; Fri, 16 Jun 2023 15:06:14 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 5CE73332B1
for <pve-devel@lists.proxmox.com>; Fri, 16 Jun 2023 15:05:44 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Fri, 16 Jun 2023 15:05:43 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 417A345B5F
for <pve-devel@lists.proxmox.com>; Fri, 16 Jun 2023 15:05:43 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Date: Fri, 16 Jun 2023 15:05:20 +0200
Message-Id: <20230616130542.199182-1-d.csapak@proxmox.com>
X-Mailer: git-send-email 2.30.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.015 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: [pve-devel] [PATCH qemu-server/manager/docs v7] cluster mapping
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 16 Jun 2023 13:06:14 -0000
this series is the remaining part to add a cluster-wide device mapping
for pci and usb devices. so that an admin can configure a device to be
availble for migration and configuring for uses that are non-root
(the existing pattern can be copied easily for other types, e.g.
markus upcoming folder sharing)
maybe the place for the docs are not optimal, if anyone has a better
suggestion, please say
pve-manager depends on docs, otherwise the onlineHelp reference
is not there
changes from v6:
* rebase on master
* moved the mapping config into its own property in the hostpci and usb
property strings, this has some advantages:
- the checking code is much cleaner
- it's better separated when we're using it
- the documented format is clearer
* added a usb code refactor patch up front, this makes the adding of the
mapped case much easer and more in line with the pci code
* adapted to fabians/wolfgans requests
- fix s/resource/mapping/ where i forgot it
- deduplicated most permission checks
- fixed the api endpoint handling (id <-> name, permission on the
correct path, correct id in the link hash)
* readded the warning in the gui for multiple devices (was accidentally
never shown in my last changes)
* added a short note in the docs that only one usb devce per node per
mapping is possible currently
changes from v5:
* rebase on master
* included docs
* adapted permission checks for restore/clone to (now) existing ones
* renamed a few variables (thanks to wolfgangs feedback)
* simplified the js filterPropertyStringList helper
* added onlineHelp where appropriate
qemu-server:
Dominik Csapak (7):
usb: refactor usb code and move some into USB module
enable cluster mapped USB devices for guests
enable cluster mapped PCI devices for guests
check_local_resources: extend for mapped resources
api: migrate preconditions: use new check_local_resources info
migration: check for mapped resources
add test for mapped pci devices
PVE/API2/Qemu.pm | 115 ++++++--
PVE/QemuMigrate.pm | 23 +-
PVE/QemuServer.pm | 216 ++++++++-------
PVE/QemuServer/PCI.pm | 256 +++++++++++++++---
PVE/QemuServer/USB.pm | 147 +++++++---
test/MigrationTest/Shared.pm | 14 +
test/cfg2cmd/q35-linux-hostpci-mapping.conf | 17 ++
.../q35-linux-hostpci-mapping.conf.cmd | 36 +++
test/cfg2cmd/q35-linux-hostpci.conf | 2 +-
test/cfg2cmd/q35-linux-hostpci.conf.cmd | 2 +-
test/run_config2command_tests.pl | 83 ++++++
11 files changed, 709 insertions(+), 202 deletions(-)
create mode 100644 test/cfg2cmd/q35-linux-hostpci-mapping.conf
create mode 100644 test/cfg2cmd/q35-linux-hostpci-mapping.conf.cmd
pve-manager:
Dominik Csapak (14):
api: add resource map api endpoints for PCI and USB
ui: parser: add helper for lists of property strings
ui: form/USBSelector: make it more flexible with nodename
ui: form: add PCIMapSelector
ui: form: add USBMapSelector
ui: qemu/PCIEdit: rework panel to add a mapped configuration
ui: qemu/USBEdit: add 'mapped' device case
ui: form: add MultiPCISelector
ui: add edit window for pci mappings
ui: add edit window for usb mappings
ui: add ResourceMapTree
ui: allow configuring pci and usb mapping
ui: window/Migrate: allow mapped devices
ui: improve permission handling for hardware
PVE/API2/Cluster.pm | 8 +
PVE/API2/Cluster/Makefile | 5 +
PVE/API2/Cluster/Mapping.pm | 53 +++++
PVE/API2/Cluster/Mapping/Makefile | 18 ++
PVE/API2/Cluster/Mapping/PCI.pm | 300 ++++++++++++++++++++++++
PVE/API2/Cluster/Mapping/USB.pm | 295 ++++++++++++++++++++++++
PVE/API2/Hardware.pm | 1 -
www/css/ext6-pve.css | 4 +
www/manager6/Makefile | 8 +
www/manager6/Parser.js | 4 +
www/manager6/data/PermPathStore.js | 1 +
www/manager6/dc/Config.js | 46 +++-
www/manager6/dc/PCIMapView.js | 106 +++++++++
www/manager6/dc/USBMapView.js | 98 ++++++++
www/manager6/form/MultiPCISelector.js | 288 +++++++++++++++++++++++
www/manager6/form/PCIMapSelector.js | 112 +++++++++
www/manager6/form/PCISelector.js | 1 +
www/manager6/form/USBMapSelector.js | 98 ++++++++
www/manager6/form/USBSelector.js | 33 ++-
www/manager6/qemu/HardwareView.js | 17 +-
www/manager6/qemu/PCIEdit.js | 314 ++++++++++++++++---------
www/manager6/qemu/USBEdit.js | 75 ++++--
www/manager6/tree/ResourceMapTree.js | 316 ++++++++++++++++++++++++++
www/manager6/window/Migrate.js | 52 ++++-
www/manager6/window/PCIMapEdit.js | 215 ++++++++++++++++++
www/manager6/window/USBMapEdit.js | 217 ++++++++++++++++++
26 files changed, 2530 insertions(+), 155 deletions(-)
create mode 100644 PVE/API2/Cluster/Mapping.pm
create mode 100644 PVE/API2/Cluster/Mapping/Makefile
create mode 100644 PVE/API2/Cluster/Mapping/PCI.pm
create mode 100644 PVE/API2/Cluster/Mapping/USB.pm
create mode 100644 www/manager6/dc/PCIMapView.js
create mode 100644 www/manager6/dc/USBMapView.js
create mode 100644 www/manager6/form/MultiPCISelector.js
create mode 100644 www/manager6/form/PCIMapSelector.js
create mode 100644 www/manager6/form/USBMapSelector.js
create mode 100644 www/manager6/tree/ResourceMapTree.js
create mode 100644 www/manager6/window/PCIMapEdit.js
create mode 100644 www/manager6/window/USBMapEdit.js
pve-docs:
Dominik Csapak (1):
qemu: add documentation about cluster device mapping
qm-pci-passthrough.adoc | 8 ++++
qm.adoc | 87 +++++++++++++++++++++++++++++++++++++++++
2 files changed, 95 insertions(+)
--
2.30.2