From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D9E70A1EB7 for ; Fri, 16 Jun 2023 14:23:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B2E8B32B6C for ; Fri, 16 Jun 2023 14:22:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 16 Jun 2023 14:22:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0389D45B3A for ; Fri, 16 Jun 2023 14:22:40 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Fri, 16 Jun 2023 14:22:08 +0200 Message-Id: <20230616122208.3946516-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.099 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH] smartmontools.default: add `-q never` to smartd_opts X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jun 2023 12:23:10 -0000 smartmontools has the option to run as 'notify' type systemd.service (see `smartd(8)` in bookworm and later), and debian-upstream uses this. If a system has no monitorable disks (observed in a HP DL380g8, where smartd does not seem to work by default with the the smart-array controller with a RAID1 configured) the smartmontools.service fails because smartd exits with 17. Adding `-q nodev0`, which should cause the exit not to be considered a failure does not work either, because type=notify does not expect the daemon to exit (or the daemon exits before notifying systemd) Tested by installing a version with this patch on the HP DL380g8 mentioned above, additionally inside a VM running PVE and a workstation upgraded to the latest 8.0 beta. Signed-off-by: Stoiko Ivanov --- debian/smartmontools.default | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/smartmontools.default b/debian/smartmontools.default index 6a8a6e2..ed6c78a 100644 --- a/debian/smartmontools.default +++ b/debian/smartmontools.default @@ -5,5 +5,5 @@ # Not needed (and not recommended) if the device is monitored by smartd #enable_smart="/dev/hda /dev/hdb" -# uncomment to pass additional options to smartd on startup -#smartd_opts="--interval=1800" +# to pass additional options to smartd on startup add them space separated +smartd_opts="-q never" -- 2.30.2