From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9607DA1D87 for ; Fri, 16 Jun 2023 11:57:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AB8FC30BBA for ; Fri, 16 Jun 2023 11:57:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 16 Jun 2023 11:57:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9150845BF0 for ; Fri, 16 Jun 2023 11:57:10 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Fri, 16 Jun 2023 11:57:07 +0200 Message-Id: <20230616095708.1323621-12-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230616095708.1323621-1-a.lauterer@proxmox.com> References: <20230616095708.1323621-1-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.088 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v4 container 11/12] migration: fail when aliased volume is detected X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jun 2023 09:57:44 -0000 Aliased volumes (referencing the same volume multiple times) can lead to unexpected behavior in a migration. Therefore, stop the migration in such a case. The check works by comparing the path returned by the storage plugin. This means that we should be able to catch the common situations where it can happen: * by referencing the same volid multiple times * having a different volid due to an aliased storage: different storage name but pointing to the same location. We decided against checking the storages themselves being aliased. It is not possible to infer that reliably from just the storage configuration options alone. Reviewed-by: Fiona Ebner Signed-off-by: Aaron Lauterer --- changes since v3: none src/PVE/LXC/Migrate.pm | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm index e3fa7a7..e7c6736 100644 --- a/src/PVE/LXC/Migrate.pm +++ b/src/PVE/LXC/Migrate.pm @@ -182,6 +182,7 @@ sub phase1 { my $volhash = {}; # 'config', 'snapshot' or 'storage' for local volumes my $volhash_errors = {}; my $abort = 0; + my $path_to_volid = {}; my $log_error = sub { my ($msg, $volid) = @_; @@ -231,6 +232,8 @@ sub phase1 { die "owned by other guest (owner = $owner)\n" if !$owner || ($owner != $self->{vmid}); + $path_to_volid->{$path}->{$volid} = 1; + if (defined($snapname)) { # we cannot migrate shapshots on local storage # exceptions: 'zfspool', 'btrfs' @@ -277,6 +280,12 @@ sub phase1 { # finally all current volumes PVE::LXC::Config->foreach_volume_full($conf, { include_unused => 1 }, $test_mp); + for my $path (keys %$path_to_volid) { + my @volids = keys $path_to_volid->{$path}->%*; + die "detected not supported aliased volumes: '" . join("', '", @volids) . "'" + if (scalar @volids > 1); + } + # additional checks for local storage foreach my $volid (keys %$volhash) { eval { -- 2.39.2