From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C8D01A1A18 for ; Thu, 15 Jun 2023 16:15:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9D83927B6C for ; Thu, 15 Jun 2023 16:14:54 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 15 Jun 2023 16:14:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7FD6B45868 for ; Thu, 15 Jun 2023 16:14:52 +0200 (CEST) From: Alexander Zeidler To: pve-devel@lists.proxmox.com Cc: Alexander Zeidler Date: Thu, 15 Jun 2023 16:14:41 +0200 Message-Id: <20230615141445.188274-1-a.zeidler@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [common.pm, lxc.pm, proxmox.com, backup.pm] Subject: [pve-devel] [PATCH v2 manager/container/guest-common 0/4] fix #3069: add pbs-entries-max to vzdump.conf X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jun 2023 14:15:24 -0000 Users reported[1] about failing backups to PBS when having a large amount of files in a directory. proxmox-backup-client has already 'entries-max' implemented. The default value is also a kind of DOS prevention feature. Overriding this parameter needs at least 'Sys.Modify' permissions. This patch series makes the new optional parameter 'pbs-entries-max' available in vzdump and vzdump.conf. [1] https://bugzilla.proxmox.com/show_bug.cgi?id=3069 Changes from v1: Incorporated Fiona's comments. For details see patch emails. pve-manager: Alexander Zeidler (2): api: backup: refactor backup permission check api: backup: add 'pbs-entries-max' to permission check & config PVE/API2/Backup.pm | 2 +- configs/vzdump.conf | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) pve-container: Alexander Zeidler (1): add 'pbs-entries-max' parameter src/PVE/VZDump/LXC.pm | 5 +++++ 1 file changed, 5 insertions(+) pve-guest-common: Alexander Zeidler (1): vzdump: schema: add 'pbs-entries-max' property src/PVE/VZDump/Common.pm | 10 ++++++++++ 1 file changed, 10 insertions(+) -- 2.39.2