From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6C5ADA1812 for ; Thu, 15 Jun 2023 13:39:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4C76925EAD for ; Thu, 15 Jun 2023 13:39:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 15 Jun 2023 13:39:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 621D745833 for ; Thu, 15 Jun 2023 13:39:04 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Thu, 15 Jun 2023 13:39:00 +0200 Message-Id: <20230615113900.107633-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230615113900.107633-1-f.ebner@proxmox.com> References: <20230615113900.107633-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH qemu 2/2] fix checks for drive mirror with bitmap X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jun 2023 11:39:35 -0000 The QAPI change for QEMU 8.0 dropped redundant has_foo parameters, but in the blockdev_mirror_common() function (which is not part of the QAPI itself but called from there) the argument pair was has_bitmap and bitmap_name rather than has_bitmap and bitmap. Reported-by: Aaron Lauterer Signed-off-by: Fiona Ebner --- ...rive-mirror-add-support-for-sync-bitmap-mode-never.patch | 4 ++-- ...03-mirror-add-check-for-bitmap-mode-without-bitmap.patch | 2 +- .../bitmap-mirror/0006-mirror-move-some-checks-to-qmp.patch | 6 +++--- .../0030-PVE-Backup-Proxmox-backup-patches-for-QEMU.patch | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/debian/patches/bitmap-mirror/0001-drive-mirror-add-support-for-sync-bitmap-mode-never.patch b/debian/patches/bitmap-mirror/0001-drive-mirror-add-support-for-sync-bitmap-mode-never.patch index a45ee6e..4d9b8b9 100644 --- a/debian/patches/bitmap-mirror/0001-drive-mirror-add-support-for-sync-bitmap-mode-never.patch +++ b/debian/patches/bitmap-mirror/0001-drive-mirror-add-support-for-sync-bitmap-mode-never.patch @@ -254,7 +254,7 @@ index 663e2b7002..9099c75992 100644 errp); if (!job) { diff --git a/blockdev.c b/blockdev.c -index e464daea58..1010b60804 100644 +index e464daea58..50e4a9c682 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2942,6 +2942,9 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs, @@ -279,7 +279,7 @@ index e464daea58..1010b60804 100644 sync = MIRROR_SYNC_MODE_FULL; } -+ if (bitmap) { ++ if (bitmap_name) { + if (granularity) { + error_setg(errp, "Granularity and bitmap cannot both be set"); + return; diff --git a/debian/patches/bitmap-mirror/0003-mirror-add-check-for-bitmap-mode-without-bitmap.patch b/debian/patches/bitmap-mirror/0003-mirror-add-check-for-bitmap-mode-without-bitmap.patch index e1cd354..302bbc5 100644 --- a/debian/patches/bitmap-mirror/0003-mirror-add-check-for-bitmap-mode-without-bitmap.patch +++ b/debian/patches/bitmap-mirror/0003-mirror-add-check-for-bitmap-mode-without-bitmap.patch @@ -16,7 +16,7 @@ Signed-off-by: Thomas Lamprecht 1 file changed, 3 insertions(+) diff --git a/blockdev.c b/blockdev.c -index 1010b60804..19f490fce7 100644 +index 50e4a9c682..e6b2b1e338 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3036,6 +3036,9 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs, diff --git a/debian/patches/bitmap-mirror/0006-mirror-move-some-checks-to-qmp.patch b/debian/patches/bitmap-mirror/0006-mirror-move-some-checks-to-qmp.patch index 7dc188b..5298342 100644 --- a/debian/patches/bitmap-mirror/0006-mirror-move-some-checks-to-qmp.patch +++ b/debian/patches/bitmap-mirror/0006-mirror-move-some-checks-to-qmp.patch @@ -62,7 +62,7 @@ index f42953837b..8f79efaa87 100644 if (bitmap_mode != BITMAP_SYNC_MODE_NEVER) { diff --git a/blockdev.c b/blockdev.c -index 19f490fce7..9a010f3a86 100644 +index e6b2b1e338..bdae211a54 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3015,7 +3015,36 @@ static void blockdev_mirror_common(const char *job_id, BlockDriverState *bs, @@ -72,7 +72,7 @@ index 19f490fce7..9a010f3a86 100644 + if ((sync == MIRROR_SYNC_MODE_BITMAP) || + (sync == MIRROR_SYNC_MODE_INCREMENTAL)) { + /* done before desugaring 'incremental' to print the right message */ -+ if (!bitmap) { ++ if (!bitmap_name) { + error_setg(errp, "Must provide a valid bitmap name for " + "'%s' sync mode", MirrorSyncMode_str(sync)); + return; @@ -93,7 +93,7 @@ index 19f490fce7..9a010f3a86 100644 + bitmap_mode = BITMAP_SYNC_MODE_ON_SUCCESS; + } + - if (bitmap) { + if (bitmap_name) { + if (sync != MIRROR_SYNC_MODE_BITMAP) { + error_setg(errp, "Sync mode '%s' not supported with bitmap.", + MirrorSyncMode_str(sync)); diff --git a/debian/patches/pve/0030-PVE-Backup-Proxmox-backup-patches-for-QEMU.patch b/debian/patches/pve/0030-PVE-Backup-Proxmox-backup-patches-for-QEMU.patch index 5049256..3753eff 100644 --- a/debian/patches/pve/0030-PVE-Backup-Proxmox-backup-patches-for-QEMU.patch +++ b/debian/patches/pve/0030-PVE-Backup-Proxmox-backup-patches-for-QEMU.patch @@ -166,7 +166,7 @@ index ca2599de44..636509b83e 100644 + hmp_handle_error(mon, error); +} diff --git a/blockdev.c b/blockdev.c -index 9a010f3a86..b9505c95d3 100644 +index bdae211a54..315a27fc09 100644 --- a/blockdev.c +++ b/blockdev.c @@ -37,6 +37,7 @@ -- 2.39.2