From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9664FA1803 for ; Thu, 15 Jun 2023 13:37:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6F8D725DD3 for ; Thu, 15 Jun 2023 13:37:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 15 Jun 2023 13:37:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AED8445827 for ; Thu, 15 Jun 2023 13:37:08 +0200 (CEST) From: Friedrich Weber To: pve-devel@lists.proxmox.com Date: Thu, 15 Jun 2023 13:36:58 +0200 Message-Id: <20230615113658.392066-1-f.weber@proxmox.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.349 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [plugin.pm] Subject: [pve-devel] [PATCH storage] content-dirs check: silently skip paths that cannot be resolved X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jun 2023 11:37:39 -0000 Since commit 8e623a2930f7aee4b3309b1f297613a250ee4698, the inequality check for content-dirs prints a warning if a content directory path could not be resolved, i.e., if `abs_path` returns undef. Among other things, `abs_path` returns undef if the path has an inner (= any but last) component that does not exist. This can happen for a storage with content type `iso,vztmpl` and `create-subdirs` set to 0, in case `template/` does not exist. In this case, the warnings printed by pvestatd are quite noisy. As missing content directories are not a problem per se, remove the warning and just ignore the directory during the inequality check. Signed-off-by: Friedrich Weber --- src/PVE/Storage/Plugin.pm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm index ab6b675..3f9f1ec 100644 --- a/src/PVE/Storage/Plugin.pm +++ b/src/PVE/Storage/Plugin.pm @@ -1396,10 +1396,7 @@ sub activate_storage { for my $vtype (sort keys $scfg->{content}->%*) { my $subdir = $class->get_subdir($scfg, $vtype); my $abs_subdir = abs_path($subdir); - if (!defined($abs_subdir)) { - warn "could not get absolute path for '$subdir' - $!\n"; - next; - } + next if !defined($abs_subdir); die "storage '$storeid' uses directory $abs_subdir for multiple content types\n" if defined($abs_subdir) && defined($resolved_subdirs->{$abs_subdir}); -- 2.39.2