From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 62369A17BD for ; Thu, 15 Jun 2023 12:43:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4926425618 for ; Thu, 15 Jun 2023 12:43:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 15 Jun 2023 12:43:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2C95E45915 for ; Thu, 15 Jun 2023 12:43:22 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Thu, 15 Jun 2023 12:42:55 +0200 Message-Id: <20230615104257.3387232-2-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230615104257.3387232-1-s.ivanov@proxmox.com> References: <20230615104257.3387232-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.100 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH proxmox-backup 1/3] file-restore: add zfs. prefix to arc_min/max settings X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jun 2023 10:43:23 -0000 Currently the values set for zfs_arc_min and zfs_arc_max are ignored by the kernel: ``` Unknown kernel command line parameters... will be passed to user space ``` module parameters provided on the commandline usually need to be prefixed with the modulename (e.g. zfs.zfs_arc_min, see [0] for a bit on related information (the issue itself is not related)). Paradoxically currently ZFS will print spurious warnings about settings being ignored when they are actually set - see [1]. Booting the debug image and connecting the shell on the serial console confirmed that the values did not seem to be set: `grep '^c_' /proc/spl/kstat/zfs/arcstats` showed half of the memory for c_max. [0] https://github.com/openzfs/zfs/issues/698 [1] https://github.com/openzfs/zfs/issues/12504 Signed-off-by: Stoiko Ivanov --- proxmox-file-restore/src/qemu_helper.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxmox-file-restore/src/qemu_helper.rs b/proxmox-file-restore/src/qemu_helper.rs index c49f80d9..12c8cabf 100644 --- a/proxmox-file-restore/src/qemu_helper.rs +++ b/proxmox-file-restore/src/qemu_helper.rs @@ -260,7 +260,7 @@ pub async fn start_vm( // NOTE: ZFS requires that the ARC can at least grow to the max transaction size of 64MB // also: setting any of min/max to zero will rather do the opposite of what one wants here &format!( - "{} panic=1 zfs_arc_min=16777216 zfs_arc_max=67108864 memhp_default_state=online_kernel", + "{} panic=1 zfs.zfs_arc_min=16777216 zfs.zfs_arc_max=67108864 memhp_default_state=online_kernel", if debug { "debug" } else { "quiet" } ), "-daemonize", -- 2.30.2