From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AF70FA136D for ; Wed, 14 Jun 2023 13:10:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 903811B202 for ; Wed, 14 Jun 2023 13:10:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 14 Jun 2023 13:10:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 43EFC4555D for ; Wed, 14 Jun 2023 13:10:23 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Wed, 14 Jun 2023 13:10:22 +0200 Message-Id: <20230614111022.1432946-2-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230614111022.1432946-1-a.lauterer@proxmox.com> References: <20230614111022.1432946-1-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.341 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH v2 manager 2/2] ui: ContentView: don't show size if it is -1 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jun 2023 11:10:54 -0000 If a disk image reports a size of '-1', something is most likely amiss. The RBD storage plugin for example returns it, if the image is broken and only remnants remain. In such a situation, instead of showing '-1 B', we bette show nothing. Signed-off-by: Aaron Lauterer --- This patch is not necessary, but I think will make it nicer to look at and see broken images. changes since v1: instead of changing the size formatter in the widget toolkit, we handle the case of size=-1 in the renderer directly www/manager6/storage/ContentView.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js index 2761b48e..29926612 100644 --- a/www/manager6/storage/ContentView.js +++ b/www/manager6/storage/ContentView.js @@ -182,7 +182,12 @@ Ext.define('PVE.storage.ContentView', { 'size': { header: gettext('Size'), width: 100, - renderer: Proxmox.Utils.format_size, + renderer: function(size) { + if (Number(size) === -1) { + return ''; + } + return Proxmox.Utils.format_size(size); + }, dataIndex: 'size', }, }; -- 2.39.2