From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3165AA1067 for ; Wed, 14 Jun 2023 10:46:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1941718631 for ; Wed, 14 Jun 2023 10:46:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 14 Jun 2023 10:46:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E829145513 for ; Wed, 14 Jun 2023 10:46:23 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Wed, 14 Jun 2023 10:46:05 +0200 Message-Id: <20230614084622.1446211-6-d.csapak@proxmox.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230614084622.1446211-1-d.csapak@proxmox.com> References: <20230614084622.1446211-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH qemu-server v6 5/6] migration: check for mapped resources X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jun 2023 08:46:25 -0000 they can only be migrated to nodes where there exists a mapping and if the migration is done offline Signed-off-by: Dominik Csapak --- chnages from v5: * renamed to $missing_mappings_by_node and $missing_mappings PVE/QemuMigrate.pm | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 09cc1d83..3975ae41 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -210,15 +210,32 @@ sub prepare { $self->{vm_was_paused} = 1 if PVE::QemuServer::vm_is_paused($vmid); } - my $loc_res = PVE::QemuServer::check_local_resources($conf, 1); - if (scalar @$loc_res) { + my ($loc_res, $mapped_res, $missing_mappings_by_node) = PVE::QemuServer::check_local_resources($conf, 1); + my $blocking_resources = []; + for my $res ($loc_res->@*) { + if (!grep($res, $mapped_res->@*)) { + push $blocking_resources->@*, $res; + } + } + if (scalar($blocking_resources->@*)) { if ($self->{running} || !$self->{opts}->{force}) { - die "can't migrate VM which uses local devices: " . join(", ", @$loc_res) . "\n"; + die "can't migrate VM which uses local devices: " . join(", ", $blocking_resources->@*) . "\n"; } else { $self->log('info', "migrating VM which uses local devices"); } } + if (scalar($mapped_res->@*)) { + my $missing_mappings = $missing_mappings_by_node->{$self->{node}}; + if ($running) { + die "can't migrate running VM which uses mapped devices: " . join(", ", $mapped_res->@*) . "\n"; + } elsif (scalar($missing_mappings->@*)) { + die "can't migrate to '$self->{node}': missing mapped devices " . join(", ", $missing_mappings->@*) . "\n"; + } else { + $self->log('info', "migrating VM which uses mapped local devices"); + } + } + my $vollist = PVE::QemuServer::get_vm_volumes($conf); my $storages = {}; -- 2.30.2