From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 35646A0717 for ; Tue, 13 Jun 2023 15:44:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 164BC308FA for ; Tue, 13 Jun 2023 15:44:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 13 Jun 2023 15:44:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A312F44F7B for ; Tue, 13 Jun 2023 15:44:04 +0200 (CEST) From: Alexander Zeidler To: pve-devel@lists.proxmox.com Cc: Alexander Zeidler Date: Tue, 13 Jun 2023 15:42:51 +0200 Message-Id: <20230613134254.153081-2-a.zeidler@proxmox.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230613134254.153081-1-a.zeidler@proxmox.com> References: <20230613134254.153081-1-a.zeidler@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] [PATCH manager 1/4] api: backup: refactor backup permission check X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jun 2023 13:44:36 -0000 Unify style before adding another parameter check Signed-off-by: Alexander Zeidler --- PVE/API2/Backup.pm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm index 45eb47e2..cae889f4 100644 --- a/PVE/API2/Backup.pm +++ b/PVE/API2/Backup.pm @@ -49,8 +49,11 @@ sub assert_param_permission_common { raise_param_exc({ $key => "Only root may set this option."}) if exists $param->{$key}; } - if (defined($param->{bwlimit}) || defined($param->{ionice}) || defined($param->{performance})) { - $rpcenv->check($user, "/", [ 'Sys.Modify' ]); + for my $key (qw(bwlimit ionice performance)) { + if (defined($param->{$key})) { + $rpcenv->check($user, "/", [ 'Sys.Modify' ]); + last; + } } } -- 2.39.2